fix: strip exported TypeScript function overloads

dummdidumm · dummdidumm · commit f2690bd570cd · 2024-11-27T16:50:40.000+01:00
fixes #14455
diff --git a/.changeset/shy-starfishes-type.md b/.changeset/shy-starfishes-type.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: strip exported TypeScript function overloads
diff --git a/packages/svelte/src/compiler/phases/1-parse/remove_typescript_nodes.js b/packages/svelte/src/compiler/phases/1-parse/remove_typescript_nodes.js
@@ -36,7 +36,11 @@ const visitors = {
 		if (node.exportKind === 'type') return b.empty;
 
 		if (node.declaration) {
-			return context.next();
+			const result = context.next();
+			if (result?.declaration?.type === 'EmptyStatement') {
+				return b.empty;
+			}
+			return result;
 		}
 
 		if (node.specifiers) {
diff --git a/packages/svelte/tests/runtime-runes/samples/typescript/main.svelte b/packages/svelte/tests/runtime-runes/samples/typescript/main.svelte
@@ -27,6 +27,10 @@
 		export type Foo = true
 	}
 
+	export function overload(a: boolean): boolean;
+	export function overload(b: string): number;
+	export function overload(c: any): any {}
+
 	export type { Hello };
 </script>
 

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'svelte': patch
 +---
++
 +fix: strip exported TypeScript function overloads
Original file line number	Diff line number	Diff line change
`@@ -27,6 +27,10 @@`
`27`	`27`	`export type Foo = true`
`28`	`28`	`}`
`29`	`29`
	`30`	`+ export function overload(a: boolean): boolean;`
	`31`	`+ export function overload(b: string): number;`
	`32`	`+ export function overload(c: any): any {}`
	`33`	`+`
`30`	`34`	`export type { Hello };`
`31`	`35`	`</script>`
`32`	`36`