Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: swift-server/swift-openapi-async-http-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.2
Choose a base ref
...
head repository: swift-server/swift-openapi-async-http-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.3
Choose a head ref
  • 3 commits
  • 7 files changed
  • 1 contributor

Commits on Aug 1, 2023

  1. [AHCTransport] Consistent style for initializing local variables (#10)

    [AHCTransport] Consistent style for initializing local variables
    
    ### Motivation
    
    Move to a consistent style when initializing local variables, always use `let foo = Foo(...)` vs `let foo: Foo = .init(...)`.
    
    ### Modifications
    
    Updated all occurrences of the latter to use the former.
    
    ### Result
    
    Consistent local variable initialization.
    
    ### Test Plan
    
    All tests passed.
    
    
    Reviewed by: gjcairo, simonjbeaumont
    
    Builds:
         ✔︎ pull request validation (5.8) - Build finished. 
         ✔︎ pull request validation (5.9) - Build finished. 
         ✔︎ pull request validation (nightly) - Build finished. 
         ✔︎ pull request validation (soundness) - Build finished. 
    
    #10
    czechboy0 authored Aug 1, 2023
    Configuration menu
    Copy the full SHA
    762f5e5 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. Enable strict concurrency checking in CI (#11)

    Enable strict concurrency checking in CI
    
    ### Motivation
    
    To further avoid concurrency bugs, enable complete concurrency checking in CI.
    
    ### Modifications
    
    Added the compiler flag to the docker-compose scripts.
    
    ### Result
    
    If a warning of this nature comes up, because we have warnings-as-errors, it'll fail CI.
    
    ### Test Plan
    
    Locally built without any warnings with the flag enabled.
    
    
    Reviewed by: glbrntt
    
    Builds:
         ✔︎ pull request validation (5.8) - Build finished. 
         ✔︎ pull request validation (5.9) - Build finished. 
         ✔︎ pull request validation (nightly) - Build finished. 
         ✔︎ pull request validation (soundness) - Build finished. 
    
    #11
    czechboy0 authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    95bb2f8 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Adopt the new shared HTTP client (#13)

    Adopt the new shared HTTP client
    
    ### Motivation
    
    Now that SwiftNIO/AsyncHTTPClient have a singleton variant of the `EventLoopGroup`, which allows creating an `HTTPClient` without any argument, let's simplify the initializer of the transport to take advantage of it - bringing it in line with the URLSession transport.
    
    ### Modifications
    
    Default the HTTPClient to a new one with a default event loop group, and remove the mandatory shutdown call.
    
    ### Result
    
    Adopters can more easily create the AHC transport.
    
    ### Test Plan
    
    N/A
    
    
    Reviewed by: dnadoba, glbrntt
    
    Builds:
         ✔︎ pull request validation (5.8) - Build finished. 
         ✔︎ pull request validation (5.9) - Build finished. 
         ✔︎ pull request validation (nightly) - Build finished. 
         ✔︎ pull request validation (soundness) - Build finished. 
    
    #13
    czechboy0 authored Aug 29, 2023
    Configuration menu
    Copy the full SHA
    91dfd35 View commit details
    Browse the repository at this point in the history
Loading