Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: swift-server/swift-openapi-async-http-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.2.1
Choose a base ref
...
head repository: swift-server/swift-openapi-async-http-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.2.2
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Sep 7, 2023

  1. Fix double encoding of path parameters (#15) 

    Fix double encoding of path parameters

### Motivation

Fixes apple/swift-openapi-generator#251.

### Modifications

Use the already escaped path setter on `URLComponents` to avoid the second encoding pass.

### Result

Path parameters that needed escaping are only escaped once, not twice.

### Test Plan

Adapted the existing unit test to cover a path item that needs escaping.


Reviewed by: simonjbeaumont

Builds:
     ✔︎ pull request validation (5.8) - Build finished. 
     ✔︎ pull request validation (5.9) - Build finished. 
     ✔︎ pull request validation (nightly) - Build finished. 
     ✔︎ pull request validation (soundness) - Build finished. 

#15
    @czechboy0
    czechboy0 authored Sep 7, 2023
    Configuration menu
    Copy the full SHA
    7e40bff View commit details
    Browse the repository at this point in the history
Loading