Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: swift-server/swift-openapi-async-http-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.2.2
Choose a base ref
...
head repository: swift-server/swift-openapi-async-http-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.2.3
Choose a head ref
  • 1 commit
  • 2 files changed
  • 2 contributors

Commits on Sep 18, 2023

  1. Adopt a custom shared client (#18) 

    ### Motivation

We previously defaulted the HTTPClient to .init(), but that's not
correct as it was never getting shut down.

### Modifications

Instead of creating a new client, just introduce our own shared one and
use that as the default value.

Once AHC provides a shared client, we can default to that in the
configuration initializer.

### Result

No more crashing clients on dealloc.

### Test Plan

All tests pass.

---------

Co-authored-by: David Nadoba <dnadoba@gmail.com>
    @czechboy0 @dnadoba
    czechboy0 and dnadoba authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    f228a33 View commit details
    Browse the repository at this point in the history
Loading