the string "0" is a valid service identifier

xabbuh · xabbuh · commit 9150ac7ec174 · 2019-01-15T14:43:24.000+01:00
diff --git a/Loader/XmlFileLoader.php b/Loader/XmlFileLoader.php
@@ -496,7 +496,7 @@ private function getArgumentsAsPhp(\DOMElement $node, $name, $file, $lowercase =
 
             switch ($arg->getAttribute('type')) {
                 case 'service':
-                    if (!$arg->getAttribute('id')) {
+                    if ('' === $arg->getAttribute('id')) {
                         throw new InvalidArgumentException(sprintf('Tag "<%s>" with type="service" has no or empty "id" attribute in "%s".', $name, $file));
                     }
                     if ($arg->hasAttribute('strict')) {
@@ -549,7 +549,7 @@ private function getArgumentsAsPhp(\DOMElement $node, $name, $file, $lowercase =
      * @param \DOMNode $node
      * @param mixed    $name
      *
-     * @return array
+     * @return \DOMElement[]
      */
     private function getChildren(\DOMNode $node, $name)
     {
diff --git a/Tests/Fixtures/xml/services6.xml b/Tests/Fixtures/xml/services6.xml
@@ -61,5 +61,9 @@
     </service>
     <service id="alias_for_foo" alias="foo" />
     <service id="another_alias_for_foo" alias="foo" public="false" />
+    <service id="0" class="FooClass" />
+    <service id="1" class="FooClass">
+      <argument type="service" id="0" />
+    </service>
   </services>
 </container>

Original file line number	Diff line number	Diff line change
`@@ -496,7 +496,7 @@ private function getArgumentsAsPhp(\DOMElement $node, $name, $file, $lowercase =`
`496`	`496`
`497`	`497`	`switch ($arg->getAttribute('type')) {`
`498`	`498`	`case 'service':`
`499`		`- if (!$arg->getAttribute('id')) {`
	`499`	`+ if ('' === $arg->getAttribute('id')) {`
`500`	`500`	`throw new InvalidArgumentException(sprintf('Tag "<%s>" with type="service" has no or empty "id" attribute in "%s".', $name, $file));`
`501`	`501`	`}`
`502`	`502`	`if ($arg->hasAttribute('strict')) {`
`@@ -549,7 +549,7 @@ private function getArgumentsAsPhp(\DOMElement $node, $name, $file, $lowercase =`
`549`	`549`	`* @param \DOMNode $node`
`550`	`550`	`* @param mixed $name`
`551`	`551`	`*`
`552`		`- * @return array`
	`552`	`+ * @return \DOMElement[]`
`553`	`553`	`*/`
`554`	`554`	`private function getChildren(\DOMNode $node, $name)`
`555`	`555`	`{`