Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/dependency-injection
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.2.3
Choose a base ref
...
head repository: symfony/dependency-injection
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.2.4
Choose a head ref
  • 9 commits
  • 18 files changed
  • 6 contributors

Commits on Jan 10, 2025

  1. Configuration menu
    Copy the full SHA
    6094d2c View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2025

  1. [DependencyInjection] Fix cloned lazy services not sharing their depe…

    …ndencies when dumped with PhpDumper
    pvandommelen authored and nicolas-grekas committed Feb 10, 2025
    Configuration menu
    Copy the full SHA
    3f58cc9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    495e951 View commit details
    Browse the repository at this point in the history
  3. bug #59713 [DependencyInjection] Do not preload functions (biozshock)

    This PR was squashed before being merged into the 6.4 branch.
    
    Discussion
    ----------
    
    [DependencyInjection] Do not preload functions
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.4
    | Bug fix?      | yes
    | New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
    | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
    | License       | MIT
    
    Ensure `preload.php` does not have functions in preloaded class names:
    ```
    $ grep "current" var/cache/prod/App_KernelProdContainer.preload.php
    $classes[] = 'current';
    ```
    
    Happens because the DI declares a factory, which uses built-in `\current`: https://github.com/symfony/symfony/blob/v6.4.18/src/Symfony/Bundle/FrameworkBundle/Resources/config/http_client.php#L39
    And then the "class" is added by https://github.com/symfony/symfony/blob/v6.4.18/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php#L2317
    
    Similar to the #36866
    
    Commits
    -------
    
    b52b760dff2 [DependencyInjection] Do not preload functions
    nicolas-grekas committed Feb 10, 2025
    Configuration menu
    Copy the full SHA
    e066329 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2025

  1. Merge branch '6.4' into 7.2

    * 6.4:
      [WebProfilerBundle] Fix tests
      [Cache] Tests for Redis Replication with cache
      [BrowserKit] Fix submitting forms with empty file fields
      [WebProfilerBundle] Fix interception for non conventional redirects
      [DependencyInjection] Do not preload functions
      [DependencyInjection] Fix cloned lazy services not sharing their dependencies when dumped with PhpDumper
      [HttpClient] Fix activity tracking leading to negative timeout errors
      [Security] Return null instead of empty username to fix deprecation notice
      [DependencyInjection] Fix env default processor with scalar node
    nicolas-grekas committed Feb 11, 2025
    Configuration menu
    Copy the full SHA
    7c31147 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2025

  1. Fix merge

    nicolas-grekas committed Feb 12, 2025
    Configuration menu
    Copy the full SHA
    e54b539 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2025

  1. Configuration menu
    Copy the full SHA
    b343c3b View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2025

  1. Configuration menu
    Copy the full SHA
    2eba71f View commit details
    Browse the repository at this point in the history
  2. Merge branch '6.4' into 7.2

    * 6.4:
      [DependencyInjection] Defer check for circular references instead of skipping them.
      [Validator] Synchronize IBAN formats
    chalasr committed Feb 21, 2025
    Configuration menu
    Copy the full SHA
    f0a1614 View commit details
    Browse the repository at this point in the history
Loading