Migrate to static data providers using rector/rector

OskarStark · nicolas-grekas · commit d0ec59b38d87 · 2023-02-14T09:03:56.000+01:00
diff --git a/Tests/DataCollector/DoctrineDataCollectorTest.php b/Tests/DataCollector/DoctrineDataCollectorTest.php
@@ -134,7 +134,7 @@ public function testSerialization($param, array $types, $expected)
         $this->assertTrue($collectedQueries['default'][0]['runnable']);
     }
 
-    public function paramProvider(): array
+    public static function paramProvider(): array
     {
         return [
             ['some value', [], 'some value'],
diff --git a/Tests/DataCollector/DoctrineDataCollectorWithDebugStackTest.php b/Tests/DataCollector/DoctrineDataCollectorWithDebugStackTest.php
@@ -107,7 +107,7 @@ public function testSerialization($param, array $types, $expected, $explainable,
         $this->assertSame($runnable, $collectedQueries['default'][0]['runnable']);
     }
 
-    public function paramProvider(): array
+    public static function paramProvider(): array
     {
         return [
             ['some value', [], 'some value', true],
diff --git a/Tests/DependencyInjection/DoctrineExtensionTest.php b/Tests/DependencyInjection/DoctrineExtensionTest.php
@@ -84,7 +84,7 @@ public function testFixManagersAutoMappingsWithTwoAutomappings()
         $method->invoke($this->extension, $emConfigs, $bundles);
     }
 
-    public function getAutomappingData()
+    public static function getAutomappingData()
     {
         return [
             [
@@ -197,7 +197,7 @@ public function testMappingTypeDetection()
         $this->assertSame($mappingType, \PHP_VERSION_ID < 80000 ? 'annotation' : 'attribute');
     }
 
-    public function providerBasicDrivers()
+    public static function providerBasicDrivers()
     {
         return [
             ['doctrine.orm.cache.apc.class',       ['type' => 'apc']],
@@ -276,7 +276,7 @@ public function testUnrecognizedCacheDriverException()
         $this->invokeLoadCacheDriver($objectManager, $container, $cacheName);
     }
 
-    public function providerBundles()
+    public static function providerBundles()
     {
         yield ['AnnotationsBundle', 'annotation', '/Entity'];
         yield ['AnnotationsOneLineBundle', 'annotation', '/Entity'];
diff --git a/Tests/Form/ChoiceList/ORMQueryBuilderLoaderTest.php b/Tests/Form/ChoiceList/ORMQueryBuilderLoaderTest.php
@@ -262,15 +262,15 @@ public function testEmbeddedIdentifierName()
         $loader->getEntitiesByIds('id.value', [1, '', 2, 3, 'foo']);
     }
 
-    public function provideGuidEntityClasses()
+    public static function provideGuidEntityClasses()
     {
         return [
             ['Symfony\Bridge\Doctrine\Tests\Fixtures\GuidIdEntity'],
             ['Symfony\Bridge\Doctrine\Tests\Fixtures\UuidIdEntity'],
         ];
     }
 
-    public function provideUidEntityClasses()
+    public static function provideUidEntityClasses()
     {
         return [
             ['Symfony\Bridge\Doctrine\Tests\Fixtures\UuidIdEntity'],
diff --git a/Tests/Form/Type/EntityTypeTest.php b/Tests/Form/Type/EntityTypeTest.php
@@ -158,7 +158,7 @@ public function testChoiceTranslationDomainIsDisabledByDefault($expanded)
         }
     }
 
-    public function choiceTranslationDomainProvider()
+    public static function choiceTranslationDomainProvider()
     {
         return [
             [false],
diff --git a/Tests/Logger/DbalLoggerTest.php b/Tests/Logger/DbalLoggerTest.php
@@ -43,7 +43,7 @@ public function testLog($sql, $params, $logParams)
         $dbalLogger->startQuery($sql, $params);
     }
 
-    public function getLogFixtures()
+    public static function getLogFixtures()
     {
         return [
             ['SQL', null, []],
diff --git a/Tests/Middleware/Debug/MiddlewareTest.php b/Tests/Middleware/Debug/MiddlewareTest.php
@@ -79,7 +79,7 @@ private function getResourceFromString(string $str)
         return $res;
     }
 
-    public function provideExecuteMethod(): array
+    public static function provideExecuteMethod(): array
     {
         return [
             'executeStatement' => [
@@ -173,7 +173,7 @@ public function testWithParamBound(callable $executeMethod)
         $this->assertGreaterThan(0, $debug[1]['executionMS']);
     }
 
-    public function provideEndTransactionMethod(): array
+    public static function provideEndTransactionMethod(): array
     {
         return [
             'commit' => [
@@ -223,7 +223,7 @@ public function testTransaction(callable $endTransactionMethod, string $expected
         $this->assertGreaterThan(0, $debug[6]['executionMS']);
     }
 
-    public function provideExecuteAndEndTransactionMethods(): array
+    public static function provideExecuteAndEndTransactionMethods(): array
     {
         return [
             'commit and exec' => [
diff --git a/Tests/PropertyInfo/DoctrineExtractorTest.php b/Tests/PropertyInfo/DoctrineExtractorTest.php
@@ -146,7 +146,7 @@ public function testExtractEnum()
         $this->assertNull($this->createExtractor()->getTypes(DoctrineEnum::class, 'enumCustom', []));
     }
 
-    public function typesProvider()
+    public static function typesProvider()
     {
         $provider = [
             ['id', [new Type(Type::BUILTIN_TYPE_INT)]],
diff --git a/Tests/Types/UlidTypeTest.php b/Tests/Types/UlidTypeTest.php
@@ -140,7 +140,7 @@ public function testGetGuidTypeDeclarationSQL(AbstractPlatform $platform, string
         $this->assertEquals($expectedDeclaration, $this->type->getSqlDeclaration(['length' => 36], $platform));
     }
 
-    public function provideSqlDeclarations(): array
+    public static function provideSqlDeclarations(): array
     {
         return [
             [new PostgreSQLPlatform(), 'UUID'],
diff --git a/Tests/Types/UuidTypeTest.php b/Tests/Types/UuidTypeTest.php
@@ -152,7 +152,7 @@ public function testGetGuidTypeDeclarationSQL(AbstractPlatform $platform, string
         $this->assertEquals($expectedDeclaration, $this->type->getSqlDeclaration(['length' => 36], $platform));
     }
 
-    public function provideSqlDeclarations(): array
+    public static function provideSqlDeclarations(): array
     {
         return [
             [new PostgreSQLPlatform(), 'UUID'],
diff --git a/Tests/Validator/Constraints/UniqueEntityValidatorTest.php b/Tests/Validator/Constraints/UniqueEntityValidatorTest.php
@@ -186,7 +186,7 @@ public function testValidateUniqueness(UniqueEntity $constraint)
             ->assertRaised();
     }
 
-    public function provideUniquenessConstraints(): iterable
+    public static function provideUniquenessConstraints(): iterable
     {
         yield 'Doctrine style' => [new UniqueEntity([
             'message' => 'myMessage',
@@ -221,7 +221,7 @@ public function testValidateCustomErrorPath(UniqueEntity $constraint)
             ->assertRaised();
     }
 
-    public function provideConstraintsWithCustomErrorPath(): iterable
+    public static function provideConstraintsWithCustomErrorPath(): iterable
     {
         yield 'Doctrine style' => [new UniqueEntity([
             'message' => 'myMessage',
@@ -282,7 +282,7 @@ public function testValidateUniquenessWithIgnoreNullDisabled(UniqueEntity $const
             ->assertRaised();
     }
 
-    public function provideConstraintsWithIgnoreNullDisabled(): iterable
+    public static function provideConstraintsWithIgnoreNullDisabled(): iterable
     {
         yield 'Doctrine style' => [new UniqueEntity([
             'message' => 'myMessage',
@@ -331,7 +331,7 @@ public function testNoValidationIfFirstFieldIsNullAndNullValuesAreIgnored(Unique
         $this->assertNoViolation();
     }
 
-    public function provideConstraintsWithIgnoreNullEnabled(): iterable
+    public static function provideConstraintsWithIgnoreNullEnabled(): iterable
     {
         yield 'Doctrine style' => [new UniqueEntity([
             'message' => 'myMessage',
@@ -432,7 +432,7 @@ function () use ($entity) {
         $this->assertNoViolation();
     }
 
-    public function provideConstraintsWithCustomRepositoryMethod(): iterable
+    public static function provideConstraintsWithCustomRepositoryMethod(): iterable
     {
         yield 'Doctrine style' => [new UniqueEntity([
             'message' => 'myMessage',
@@ -473,7 +473,7 @@ public function testValidateResultTypes($entity1, $result)
         $this->assertNoViolation();
     }
 
-    public function resultTypesProvider()
+    public static function resultTypesProvider()
     {
         $entity = new SingleIntIdEntity(1, 'foo');
 
@@ -886,7 +886,7 @@ public function testValueCanBeNull()
         $this->assertNoViolation();
     }
 
-    public function resultWithEmptyIterator(): array
+    public static function resultWithEmptyIterator(): array
     {
         $entity = new SingleIntIdEntity(1, 'foo');
 
diff --git a/Tests/Validator/DoctrineLoaderTest.php b/Tests/Validator/DoctrineLoaderTest.php
@@ -209,7 +209,7 @@ public function testClassValidator(bool $expected, string $classValidatorRegexp
         $this->assertSame($expected, $doctrineLoader->loadClassMetadata($classMetadata));
     }
 
-    public function regexpProvider()
+    public static function regexpProvider()
     {
         return [
             [false, null],

Original file line number	Diff line number	Diff line change
`@@ -134,7 +134,7 @@ public function testSerialization($param, array $types, $expected)`
`134`	`134`	`$this->assertTrue($collectedQueries['default'][0]['runnable']);`
`135`	`135`	`}`
`136`	`136`
`137`		`- public function paramProvider(): array`
	`137`	`+ public static function paramProvider(): array`
`138`	`138`	`{`
`139`	`139`	`return [`
`140`	`140`	`['some value', [], 'some value'],`
Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ public function testSerialization($param, array $types, $expected, $explainable,`
`107`	`107`	`$this->assertSame($runnable, $collectedQueries['default'][0]['runnable']);`
`108`	`108`	`}`
`109`	`109`
`110`		`- public function paramProvider(): array`
	`110`	`+ public static function paramProvider(): array`
`111`	`111`	`{`
`112`	`112`	`return [`
`113`	`113`	`['some value', [], 'some value', true],`
Original file line number	Diff line number	Diff line change
`@@ -84,7 +84,7 @@ public function testFixManagersAutoMappingsWithTwoAutomappings()`
`84`	`84`	`$method->invoke($this->extension, $emConfigs, $bundles);`
`85`	`85`	`}`
`86`	`86`
`87`		`- public function getAutomappingData()`
	`87`	`+ public static function getAutomappingData()`
`88`	`88`	`{`
`89`	`89`	`return [`
`90`	`90`	`[`
`@@ -197,7 +197,7 @@ public function testMappingTypeDetection()`
`197`	`197`	`$this->assertSame($mappingType, \PHP_VERSION_ID < 80000 ? 'annotation' : 'attribute');`
`198`	`198`	`}`
`199`	`199`
`200`		`- public function providerBasicDrivers()`
	`200`	`+ public static function providerBasicDrivers()`
`201`	`201`	`{`
`202`	`202`	`return [`
`203`	`203`	`['doctrine.orm.cache.apc.class', ['type' => 'apc']],`
`@@ -276,7 +276,7 @@ public function testUnrecognizedCacheDriverException()`
`276`	`276`	`$this->invokeLoadCacheDriver($objectManager, $container, $cacheName);`
`277`	`277`	`}`
`278`	`278`
`279`		`- public function providerBundles()`
	`279`	`+ public static function providerBundles()`
`280`	`280`	`{`
`281`	`281`	`yield ['AnnotationsBundle', 'annotation', '/Entity'];`
`282`	`282`	`yield ['AnnotationsOneLineBundle', 'annotation', '/Entity'];`
Original file line number	Diff line number	Diff line change
`@@ -262,15 +262,15 @@ public function testEmbeddedIdentifierName()`
`262`	`262`	`$loader->getEntitiesByIds('id.value', [1, '', 2, 3, 'foo']);`
`263`	`263`	`}`
`264`	`264`
`265`		`- public function provideGuidEntityClasses()`
	`265`	`+ public static function provideGuidEntityClasses()`
`266`	`266`	`{`
`267`	`267`	`return [`
`268`	`268`	`['Symfony\Bridge\Doctrine\Tests\Fixtures\GuidIdEntity'],`
`269`	`269`	`['Symfony\Bridge\Doctrine\Tests\Fixtures\UuidIdEntity'],`
`270`	`270`	`];`
`271`	`271`	`}`
`272`	`272`
`273`		`- public function provideUidEntityClasses()`
	`273`	`+ public static function provideUidEntityClasses()`
`274`	`274`	`{`
`275`	`275`	`return [`
`276`	`276`	`['Symfony\Bridge\Doctrine\Tests\Fixtures\UuidIdEntity'],`
Original file line number	Diff line number	Diff line change
`@@ -158,7 +158,7 @@ public function testChoiceTranslationDomainIsDisabledByDefault($expanded)`
`158`	`158`	`}`
`159`	`159`	`}`
`160`	`160`
`161`		`- public function choiceTranslationDomainProvider()`
	`161`	`+ public static function choiceTranslationDomainProvider()`
`162`	`162`	`{`
`163`	`163`	`return [`
`164`	`164`	`[false],`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public function testLog($sql, $params, $logParams)`
`43`	`43`	`$dbalLogger->startQuery($sql, $params);`
`44`	`44`	`}`
`45`	`45`
`46`		`- public function getLogFixtures()`
	`46`	`+ public static function getLogFixtures()`
`47`	`47`	`{`
`48`	`48`	`return [`
`49`	`49`	`['SQL', null, []],`
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ private function getResourceFromString(string $str)`
`79`	`79`	`return $res;`
`80`	`80`	`}`
`81`	`81`
`82`		`- public function provideExecuteMethod(): array`
	`82`	`+ public static function provideExecuteMethod(): array`
`83`	`83`	`{`
`84`	`84`	`return [`
`85`	`85`	`'executeStatement' => [`
`@@ -173,7 +173,7 @@ public function testWithParamBound(callable $executeMethod)`
`173`	`173`	`$this->assertGreaterThan(0, $debug[1]['executionMS']);`
`174`	`174`	`}`
`175`	`175`
`176`		`- public function provideEndTransactionMethod(): array`
	`176`	`+ public static function provideEndTransactionMethod(): array`
`177`	`177`	`{`
`178`	`178`	`return [`
`179`	`179`	`'commit' => [`
`@@ -223,7 +223,7 @@ public function testTransaction(callable $endTransactionMethod, string $expected`
`223`	`223`	`$this->assertGreaterThan(0, $debug[6]['executionMS']);`
`224`	`224`	`}`
`225`	`225`
`226`		`- public function provideExecuteAndEndTransactionMethods(): array`
	`226`	`+ public static function provideExecuteAndEndTransactionMethods(): array`
`227`	`227`	`{`
`228`	`228`	`return [`
`229`	`229`	`'commit and exec' => [`
Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,7 @@ public function testExtractEnum()`
`146`	`146`	`$this->assertNull($this->createExtractor()->getTypes(DoctrineEnum::class, 'enumCustom', []));`
`147`	`147`	`}`
`148`	`148`
`149`		`- public function typesProvider()`
	`149`	`+ public static function typesProvider()`
`150`	`150`	`{`
`151`	`151`	`$provider = [`
`152`	`152`	`['id', [new Type(Type::BUILTIN_TYPE_INT)]],`
Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ public function testGetGuidTypeDeclarationSQL(AbstractPlatform $platform, string`
`140`	`140`	`$this->assertEquals($expectedDeclaration, $this->type->getSqlDeclaration(['length' => 36], $platform));`
`141`	`141`	`}`
`142`	`142`
`143`		`- public function provideSqlDeclarations(): array`
	`143`	`+ public static function provideSqlDeclarations(): array`
`144`	`144`	`{`
`145`	`145`	`return [`
`146`	`146`	`[new PostgreSQLPlatform(), 'UUID'],`
Original file line number	Diff line number	Diff line change
`@@ -152,7 +152,7 @@ public function testGetGuidTypeDeclarationSQL(AbstractPlatform $platform, string`
`152`	`152`	`$this->assertEquals($expectedDeclaration, $this->type->getSqlDeclaration(['length' => 36], $platform));`
`153`	`153`	`}`
`154`	`154`
`155`		`- public function provideSqlDeclarations(): array`
	`155`	`+ public static function provideSqlDeclarations(): array`
`156`	`156`	`{`
`157`	`157`	`return [`
`158`	`158`	`[new PostgreSQLPlatform(), 'UUID'],`