Skip to content

Error during installation of recipe does not revert everything back #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nesl247 opened this issue Oct 24, 2017 · 3 comments
Closed

Error during installation of recipe does not revert everything back #194

nesl247 opened this issue Oct 24, 2017 · 3 comments

Comments

@nesl247
Copy link

nesl247 commented Oct 24, 2017

I discovered this when I was dealing with symfony/symfony#24683. The issue is that if you install a recipe, and an error occurs for any reason, any generated files are not removed, nor is .gitignore and composer.lock reverted back to it's original state.
@xabbuh xabbuh mentioned this issue Oct 24, 2017
Closed
@weaverryan
Copy link
Member

I’ve also hit this issue, typically in a similar way - i.e. cache clear fails, then things are partially reverted.

Would the desired behavior be to fully uninstall the recipes?

@nesl247
Copy link
Author

nesl247 commented Oct 25, 2017

That would be my expected outcome. If it fails to install, revert all changes made by the recipe. I'm gonna guess this isn't possible though because the script that is being run is run after flex has already performed it's changes.

@fabpot
Copy link
Member

fabpot commented Oct 26, 2017

closing as a duplicate of #142

@fabpot fabpot closed this as completed Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fabpot @weaverryan @nesl247