Remove calls to no-op functions, deprecated in PHP 8.5

nicolas-grekas · nicolas-grekas · commit bcc7d5ead107 · 2025-08-13T12:01:27.000+02:00
diff --git a/Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php b/Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php
@@ -36,7 +36,6 @@ protected function setUp(): void
         // Normalize intl. configuration settings.
         if (\extension_loaded('intl')) {
             $this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);
-            $this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);
         }
 
         // Since we test against "de_AT", we need the full implementation
@@ -55,7 +54,6 @@ protected function tearDown(): void
 
         if (\extension_loaded('intl')) {
             ini_set('intl.use_exceptions', $this->initialTestCaseUseException);
-            ini_set('intl.error_level', $this->initialTestCaseErrorLevel);
         }
     }
 
@@ -346,6 +344,7 @@ public function testReverseTransformFiveDigitYearsWithTimestamp()
 
     /**
      * @requires extension intl
+     * @requires PHP < 8.5
      */
     public function testReverseTransformWrapsIntlErrorsWithErrorLevel()
     {
@@ -378,6 +377,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()
 
     /**
      * @requires extension intl
+     * @requires PHP < 8.5
      */
     public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()
     {
diff --git a/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php b/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
@@ -21,14 +21,12 @@ class NumberToLocalizedStringTransformerTest extends TestCase
     private string $defaultLocale;
 
     private $initialTestCaseUseException;
-    private $initialTestCaseErrorLevel;
 
     protected function setUp(): void
     {
         // Normalize intl. configuration settings.
         if (\extension_loaded('intl')) {
             $this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);
-            $this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);
         }
 
         $this->defaultLocale = \Locale::getDefault();
@@ -41,7 +39,6 @@ protected function tearDown(): void
 
         if (\extension_loaded('intl')) {
             ini_set('intl.use_exceptions', $this->initialTestCaseUseException);
-            ini_set('intl.error_level', $this->initialTestCaseErrorLevel);
         }
     }
 
@@ -664,6 +661,7 @@ public function testReverseTransformENotation($output, $input)
 
     /**
      * @requires extension intl
+     * @requires PHP < 8.5
      */
     public function testReverseTransformWrapsIntlErrorsWithErrorLevel()
     {
@@ -696,6 +694,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()
 
     /**
      * @requires extension intl
+     * @requires PHP < 8.5
      */
     public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()
     {
diff --git a/Tests/Extension/Core/DataTransformer/PercentToLocalizedStringTransformerTest.php b/Tests/Extension/Core/DataTransformer/PercentToLocalizedStringTransformerTest.php
@@ -21,14 +21,12 @@ class PercentToLocalizedStringTransformerTest extends TestCase
     private string $defaultLocale;
 
     private $initialTestCaseUseException;
-    private $initialTestCaseErrorLevel;
 
     protected function setUp(): void
     {
         // Normalize intl. configuration settings.
         if (\extension_loaded('intl')) {
             $this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);
-            $this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);
         }
 
         $this->defaultLocale = \Locale::getDefault();
@@ -41,7 +39,6 @@ protected function tearDown(): void
 
         if (\extension_loaded('intl')) {
             ini_set('intl.use_exceptions', $this->initialTestCaseUseException);
-            ini_set('intl.error_level', $this->initialTestCaseErrorLevel);
         }
     }
 
@@ -492,6 +489,7 @@ public function testReverseTransformForHtml5FormatWithScale()
 
     /**
      * @requires extension intl
+     * @requires PHP < 8.5
      */
     public function testReverseTransformWrapsIntlErrorsWithErrorLevel()
     {
@@ -524,6 +522,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()
 
     /**
      * @requires extension intl
+     * @requires PHP < 8.5
      */
     public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()
     {

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,6 @@ protected function setUp(): void`
`36`	`36`	`// Normalize intl. configuration settings.`
`37`	`37`	`if (\extension_loaded('intl')) {`
`38`	`38`	`$this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);`
`39`		`- $this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);`
`40`	`39`	`}`
`41`	`40`
`42`	`41`	`// Since we test against "de_AT", we need the full implementation`
`@@ -55,7 +54,6 @@ protected function tearDown(): void`
`55`	`54`
`56`	`55`	`if (\extension_loaded('intl')) {`
`57`	`56`	`ini_set('intl.use_exceptions', $this->initialTestCaseUseException);`
`58`		`- ini_set('intl.error_level', $this->initialTestCaseErrorLevel);`
`59`	`57`	`}`
`60`	`58`	`}`
`61`	`59`
`@@ -346,6 +344,7 @@ public function testReverseTransformFiveDigitYearsWithTimestamp()`
`346`	`344`
`347`	`345`	`/**`
`348`	`346`	`* @requires extension intl`
	`347`	`+ * @requires PHP < 8.5`
`349`	`348`	`*/`
`350`	`349`	`public function testReverseTransformWrapsIntlErrorsWithErrorLevel()`
`351`	`350`	`{`
`@@ -378,6 +377,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()`
`378`	`377`
`379`	`378`	`/**`
`380`	`379`	`* @requires extension intl`
	`380`	`+ * @requires PHP < 8.5`
`381`	`381`	`*/`
`382`	`382`	`public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()`
`383`	`383`	`{`
Original file line number	Diff line number	Diff line change
`@@ -21,14 +21,12 @@ class NumberToLocalizedStringTransformerTest extends TestCase`
`21`	`21`	`private string $defaultLocale;`
`22`	`22`
`23`	`23`	`private $initialTestCaseUseException;`
`24`		`- private $initialTestCaseErrorLevel;`
`25`	`24`
`26`	`25`	`protected function setUp(): void`
`27`	`26`	`{`
`28`	`27`	`// Normalize intl. configuration settings.`
`29`	`28`	`if (\extension_loaded('intl')) {`
`30`	`29`	`$this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);`
`31`		`- $this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);`
`32`	`30`	`}`
`33`	`31`
`34`	`32`	`$this->defaultLocale = \Locale::getDefault();`
`@@ -41,7 +39,6 @@ protected function tearDown(): void`
`41`	`39`
`42`	`40`	`if (\extension_loaded('intl')) {`
`43`	`41`	`ini_set('intl.use_exceptions', $this->initialTestCaseUseException);`
`44`		`- ini_set('intl.error_level', $this->initialTestCaseErrorLevel);`
`45`	`42`	`}`
`46`	`43`	`}`
`47`	`44`
`@@ -664,6 +661,7 @@ public function testReverseTransformENotation($output, $input)`
`664`	`661`
`665`	`662`	`/**`
`666`	`663`	`* @requires extension intl`
	`664`	`+ * @requires PHP < 8.5`
`667`	`665`	`*/`
`668`	`666`	`public function testReverseTransformWrapsIntlErrorsWithErrorLevel()`
`669`	`667`	`{`
`@@ -696,6 +694,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()`
`696`	`694`
`697`	`695`	`/**`
`698`	`696`	`* @requires extension intl`
	`697`	`+ * @requires PHP < 8.5`
`699`	`698`	`*/`
`700`	`699`	`public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()`
`701`	`700`	`{`
Original file line number	Diff line number	Diff line change
`@@ -21,14 +21,12 @@ class PercentToLocalizedStringTransformerTest extends TestCase`
`21`	`21`	`private string $defaultLocale;`
`22`	`22`
`23`	`23`	`private $initialTestCaseUseException;`
`24`		`- private $initialTestCaseErrorLevel;`
`25`	`24`
`26`	`25`	`protected function setUp(): void`
`27`	`26`	`{`
`28`	`27`	`// Normalize intl. configuration settings.`
`29`	`28`	`if (\extension_loaded('intl')) {`
`30`	`29`	`$this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);`
`31`		`- $this->initialTestCaseErrorLevel = ini_set('intl.error_level', 0);`
`32`	`30`	`}`
`33`	`31`
`34`	`32`	`$this->defaultLocale = \Locale::getDefault();`
`@@ -41,7 +39,6 @@ protected function tearDown(): void`
`41`	`39`
`42`	`40`	`if (\extension_loaded('intl')) {`
`43`	`41`	`ini_set('intl.use_exceptions', $this->initialTestCaseUseException);`
`44`		`- ini_set('intl.error_level', $this->initialTestCaseErrorLevel);`
`45`	`42`	`}`
`46`	`43`	`}`
`47`	`44`
`@@ -492,6 +489,7 @@ public function testReverseTransformForHtml5FormatWithScale()`
`492`	`489`
`493`	`490`	`/**`
`494`	`491`	`* @requires extension intl`
	`492`	`+ * @requires PHP < 8.5`
`495`	`493`	`*/`
`496`	`494`	`public function testReverseTransformWrapsIntlErrorsWithErrorLevel()`
`497`	`495`	`{`
`@@ -524,6 +522,7 @@ public function testReverseTransformWrapsIntlErrorsWithExceptions()`
`524`	`522`
`525`	`523`	`/**`
`526`	`524`	`* @requires extension intl`
	`525`	`+ * @requires PHP < 8.5`
`527`	`526`	`*/`
`528`	`527`	`public function testReverseTransformWrapsIntlErrorsWithExceptionsAndErrorLevel()`
`529`	`528`	`{`