Improving the exception message when the bundle name is wrong for the controller in a route

weaverryan · weaverryan · commit fd9f738fab59 · 2014-06-23T22:09:50.000-06:00
diff --git a/Controller/ControllerNameParser.php b/Controller/ControllerNameParser.php
@@ -46,6 +46,7 @@ public function __construct(KernelInterface $kernel)
      */
     public function parse($controller)
     {
+        $originalController = $controller;
         if (3 != count($parts = explode(':', $controller))) {
             throw new \InvalidArgumentException(sprintf('The "%s" controller is not a valid "a:b:c" controller string.', $controller));
         }
@@ -54,8 +55,24 @@ public function parse($controller)
         $controller = str_replace('/', '\\', $controller);
         $bundles = array();
 
-        // this throws an exception if there is no such bundle
-        foreach ($this->kernel->getBundle($bundle, false) as $b) {
+        try {
+            // this throws an exception if there is no such bundle
+            $allBundles = $this->kernel->getBundle($bundle, false);
+        } catch (\InvalidArgumentException $e) {
+            $message = sprintf(
+                'The "%s" (from the _controller value "%s") does not exist!',
+                $bundle,
+                $originalController
+            );
+
+            if ($alternative = $this->findAlternative($bundle)) {
+                $message .=  sprintf(' Did you mean "%s:%s:%s"?', $alternative, $controller, $action);
+            }
+
+            throw new \InvalidArgumentException($message);
+        }
+
+        foreach ($allBundles as $b) {
             $try = $b->getNamespace().'\\Controller\\'.$controller.'Controller';
             if (class_exists($try)) {
                 return $try.'::'.$action.'Action';
@@ -100,4 +117,27 @@ public function build($controller)
 
         throw new \InvalidArgumentException(sprintf('Unable to find a bundle that defines controller "%s".', $controller));
     }
+
+    private function findAlternative($nonExistentBundleName)
+    {
+        $bundleNames = array_map(function ($b) {
+            return $b->getName();
+        }, $this->kernel->getBundles());
+
+        $alternative = null;
+        $shortest = null;
+        foreach ($bundleNames as $bundleName) {
+            // if there's a partial match, return it immediately
+            if (false !== strpos($bundleName, $nonExistentBundleName)) {
+                return $bundleName;
+            }
+
+            $lev = levenshtein($nonExistentBundleName, $bundleName);
+            if ($lev <= strlen($nonExistentBundleName) / 3 && ($alternative === null || $lev < $shortest)) {
+                $alternative = $bundleName;
+            }
+        }
+
+        return $alternative;
+    }
 }
diff --git a/Tests/Controller/ControllerNameParserTest.php b/Tests/Controller/ControllerNameParserTest.php
@@ -107,6 +107,18 @@ public function getMissingControllersTest()
         );
     }
 
+    public function testInvalidBundleName()
+    {
+        $parser = $this->createParser();
+
+        try {
+            $parser->parse('FooFakeBundle:Fake:index');
+            $this->fail('->parse() throws a \InvalidArgumentException if the bundle does not exist');
+        } catch (\Exception $e) {
+            $this->assertInstanceOf('\InvalidArgumentException', $e, '->parse() throws a \InvalidArgumentException if the bundle does not exist');
+        }
+    }
+
     private function createParser()
     {
         $bundles = array(
@@ -121,6 +133,10 @@ private function createParser()
             ->expects($this->any())
             ->method('getBundle')
             ->will($this->returnCallback(function ($bundle) use ($bundles) {
+                if (!isset($bundles[$bundle])) {
+                    throw new \InvalidArgumentException(sprintf('Invalid bundle name "%s"', $bundle));
+                }
+
                 return $bundles[$bundle];
             }))
         ;
