Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/http-client
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.4.41
Choose a base ref
...
head repository: symfony/http-client
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.4.42
Choose a head ref
  • 3 commits
  • 3 files changed
  • 3 contributors

Commits on Jul 8, 2024

  1. Fix typo

    @OskarStark
    OskarStark committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    88cdf42 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. [Contracts][HttpClient] Skip tests when zlib's ob_gzhandler() doesn… 

    …'t exist
    @alexandre-daubois
    alexandre-daubois committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1663725 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. minor #57689 [Contracts][HttpClient] Skip tests when zlib's `ob_gzhan… 

    …dler()` doesn't exist (alexandre-daubois)

This PR was merged into the 5.4 branch.

Discussion
----------

[Contracts][HttpClient] Skip tests when zlib's `ob_gzhandler()` doesn't exist

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

When using a minimal PHP binary without enabling special ext, `ob_gzhandler` may not be available making a lot of HttpClient's tests fail. The function is used here: https://github.com/symfony/symfony/blob/7.2/src/Symfony/Contracts/HttpClient/Test/Fixtures/web/index.php#L46

Commits
-------

97e713b7f9 [Contracts][HttpClient] Skip tests when zlib's `ob_gzhandler()` doesn't exist
    @nicolas-grekas
    nicolas-grekas committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    ed17728 View commit details
    Browse the repository at this point in the history
Loading