-
-
Notifications
You must be signed in to change notification settings - Fork 50
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: symfony/mailer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.2.5
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: symfony/mailer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.2.8
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 14 commits
- 15 files changed
- 7 contributors
Commits on Jan 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d28bd44 - Browse repository at this point
Copy the full SHA d28bd44View commit details
Commits on Feb 2, 2023
-
* 5.4: Fix LICENSE CI check fixes retrieving multiple values for extra fields [String] Remove duplicates in fold maps fail with a meaningful error when a needed package is missing [DependencyInjection] Fix combinatory explosion when autowiring union and intersection types Update license years (last time) [Tests] New iteration of removing `$this` occurrences in future static data providers
Configuration menu - View commit details
-
Copy full SHA for 6342bc6 - Browse repository at this point
Copy the full SHA 6342bc6View commit details
Commits on Feb 14, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ac7d182 - Browse repository at this point
Copy the full SHA ac7d182View commit details -
* 5.4: Migrate to `static` data providers using `rector/rector`
Configuration menu - View commit details
-
Copy full SHA for 7340ea7 - Browse repository at this point
Copy the full SHA 7340ea7View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4861a4 - Browse repository at this point
Copy the full SHA d4861a4View commit details -
* 5.4: [Security] fix compat with security-core v6 use proper methods to assert exception messages contain certain strings
Configuration menu - View commit details
-
Copy full SHA for 14d57a4 - Browse repository at this point
Copy the full SHA 14d57a4View commit details
Commits on Feb 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cad785a - Browse repository at this point
Copy the full SHA cad785aView commit details
Commits on Feb 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 44ec77a - Browse repository at this point
Copy the full SHA 44ec77aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 82f4321 - Browse repository at this point
Copy the full SHA 82f4321View commit details -
* 5.4: [Translation][Mailer] Convert `$this` calls to static ones in data providers [BC Break] Make data providers for abstract test cases static use TestCase suffix for abstract tests in Tests directories Fix Request locale property doc types Bump absolute lowest dep to 4.4
Configuration menu - View commit details
-
Copy full SHA for 0e62116 - Browse repository at this point
Copy the full SHA 0e62116View commit details
Commits on Feb 21, 2023
-
minor #49431 [Mailer][Translation] Remove some
static
occurrences t……hat may cause unstable tests (alexandre-daubois) This PR was merged into the 6.3 branch. Discussion ---------- [Mailer][Translation] Remove some `static` occurrences that may cause unstable tests | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | _NA_ | License | MIT | Doc PR | _NA_ I had a little tchat with `@nicolas`-grekas who warned me that a few of my late edits on static data providers are a bit dangerous. Indeed, some helper methods were using static properties, which could lead to some leaks between test cases, and/or unstable tests. Helper classes doing so, found in `Translation` and `Mailer`, have been reverted to non-static ones. Data-providers are of course still statics and have been adapted to not use those methods. The targeted branch is 6.3 and this is intended, as requested by Nicolas. If you need any help during the backport of these edits, I'll be happy to help again! ℹ️ A lot of notifier bridges has been introduced in 6.3 and their data providers weren't updated. I also bundled this change in the PR, which should fix 6.3 pipeline as well. Finally, I updated `SmsapiTransportFactoryTest::missingRequiredOptionProvider`. As the `from` option has been made optional, the only dataset provided failed. Commits ------- 2ca9cf8988 [Mailer][Translation][Notifier] Remove some `static` occurrences that may cause unstable tests
Configuration menu - View commit details
-
Copy full SHA for e4f84c6 - Browse repository at this point
Copy the full SHA e4f84c6View commit details -
minor #49431 [Mailer][Translation] Remove some
static
occurrences t……hat may cause unstable tests (alexandre-daubois) This PR was merged into the 6.3 branch. Discussion ---------- [Mailer][Translation] Remove some `static` occurrences that may cause unstable tests | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | _NA_ | License | MIT | Doc PR | _NA_ I had a little tchat with `@nicolas`-grekas who warned me that a few of my late edits on static data providers are a bit dangerous. Indeed, some helper methods were using static properties, which could lead to some leaks between test cases, and/or unstable tests. Helper classes doing so, found in `Translation` and `Mailer`, have been reverted to non-static ones. Data-providers are of course still statics and have been adapted to not use those methods. The targeted branch is 6.3 and this is intended, as requested by Nicolas. If you need any help during the backport of these edits, I'll be happy to help again! ℹ️ A lot of notifier bridges has been introduced in 6.3 and their data providers weren't updated. I also bundled this change in the PR, which should fix 6.3 pipeline as well. Finally, I updated `SmsapiTransportFactoryTest::missingRequiredOptionProvider`. As the `from` option has been made optional, the only dataset provided failed. Commits ------- 2ca9cf8988 [Mailer][Translation][Notifier] Remove some `static` occurrences that may cause unstable tests
Configuration menu - View commit details
-
Copy full SHA for 60c5f5a - Browse repository at this point
Copy the full SHA 60c5f5aView commit details
Commits on Mar 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6330cd4 - Browse repository at this point
Copy the full SHA 6330cd4View commit details
Commits on Mar 14, 2023
-
* 5.4: Fix some Composer keywords [FrameworkBundle] Rename limiter’s `strategy` to `policy` in XSD [VarDumper] Fixed dumping of CutStub Fix test Change limit argument from string to integer. [Messenger] Fix `evaluate()` calls in `WorkerTest` [Mailer] STDOUT blocks infinitely under Windows when STDERR is filled
Configuration menu - View commit details
-
Copy full SHA for bfcfa01 - Browse repository at this point
Copy the full SHA bfcfa01View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v6.2.5...v6.2.8