Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/mailer
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.2.5
Choose a base ref
...
head repository: symfony/mailer
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v6.2.8
Choose a head ref
  • 14 commits
  • 15 files changed
  • 7 contributors

Commits on Jan 24, 2023

  1. Configuration menu
    Copy the full SHA
    d28bd44 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Merge branch '5.4' into 6.2

    * 5.4:
      Fix LICENSE CI check
      fixes retrieving multiple values for extra fields
      [String] Remove duplicates in fold maps
      fail with a meaningful error when a needed package is missing
      [DependencyInjection] Fix combinatory explosion when autowiring union and intersection types
      Update license years (last time)
      [Tests] New iteration of removing `$this` occurrences in future static data providers
    fabpot committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    6342bc6 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Configuration menu
    Copy the full SHA
    ac7d182 View commit details
    Browse the repository at this point in the history
  2. Merge branch '5.4' into 6.2

    * 5.4:
      Migrate to `static` data providers using `rector/rector`
    nicolas-grekas committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    7340ea7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d4861a4 View commit details
    Browse the repository at this point in the history
  4. Merge branch '5.4' into 6.2

    * 5.4:
      [Security] fix compat with security-core v6
      use proper methods to assert exception messages contain certain strings
    derrabus committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    14d57a4 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Merge branch '5.4' into 6.2

    * 5.4:
      CS fix
      Fix test provider
    nicolas-grekas committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    cad785a View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Configuration menu
    Copy the full SHA
    44ec77a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    82f4321 View commit details
    Browse the repository at this point in the history
  3. Merge branch '5.4' into 6.2

    * 5.4:
      [Translation][Mailer] Convert `$this` calls to static ones in data providers
      [BC Break] Make data providers for abstract test cases static
      use TestCase suffix for abstract tests in Tests directories
      Fix Request locale property doc types
      Bump absolute lowest dep to 4.4
    nicolas-grekas committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    0e62116 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. minor #49431 [Mailer][Translation] Remove some static occurrences t…

    …hat may cause unstable tests (alexandre-daubois)
    
    This PR was merged into the 6.3 branch.
    
    Discussion
    ----------
    
    [Mailer][Translation] Remove some `static` occurrences that may cause unstable tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.3
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | _NA_
    | License       | MIT
    | Doc PR        | _NA_
    
    I had a little tchat with `@nicolas`-grekas who warned me that a few of my late edits on static data providers are a bit dangerous. Indeed, some helper methods were using static properties, which could lead to some leaks between test cases, and/or unstable tests.
    
    Helper classes doing so, found in `Translation` and `Mailer`, have been reverted to non-static ones. Data-providers are of course still statics and have been adapted to not use those methods.
    
    The targeted branch is 6.3 and this is intended, as requested by Nicolas. If you need any help during the backport of these edits, I'll be happy to help again!
    
    ℹ️ A lot of notifier bridges has been introduced in 6.3 and their data providers weren't updated. I also bundled this change in the PR, which should fix 6.3 pipeline as well.
    
    Finally, I updated `SmsapiTransportFactoryTest::missingRequiredOptionProvider`. As the `from` option has been made optional, the only dataset provided failed.
    
    Commits
    -------
    
    2ca9cf8988 [Mailer][Translation][Notifier] Remove some `static` occurrences that may cause unstable tests
    nicolas-grekas committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    e4f84c6 View commit details
    Browse the repository at this point in the history
  2. minor #49431 [Mailer][Translation] Remove some static occurrences t…

    …hat may cause unstable tests (alexandre-daubois)
    
    This PR was merged into the 6.3 branch.
    
    Discussion
    ----------
    
    [Mailer][Translation] Remove some `static` occurrences that may cause unstable tests
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 6.3
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | _NA_
    | License       | MIT
    | Doc PR        | _NA_
    
    I had a little tchat with `@nicolas`-grekas who warned me that a few of my late edits on static data providers are a bit dangerous. Indeed, some helper methods were using static properties, which could lead to some leaks between test cases, and/or unstable tests.
    
    Helper classes doing so, found in `Translation` and `Mailer`, have been reverted to non-static ones. Data-providers are of course still statics and have been adapted to not use those methods.
    
    The targeted branch is 6.3 and this is intended, as requested by Nicolas. If you need any help during the backport of these edits, I'll be happy to help again!
    
    ℹ️ A lot of notifier bridges has been introduced in 6.3 and their data providers weren't updated. I also bundled this change in the PR, which should fix 6.3 pipeline as well.
    
    Finally, I updated `SmsapiTransportFactoryTest::missingRequiredOptionProvider`. As the `from` option has been made optional, the only dataset provided failed.
    
    Commits
    -------
    
    2ca9cf8988 [Mailer][Translation][Notifier] Remove some `static` occurrences that may cause unstable tests
    nicolas-grekas committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    60c5f5a View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Configuration menu
    Copy the full SHA
    6330cd4 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Merge branch '5.4' into 6.2

    * 5.4:
      Fix some Composer keywords
      [FrameworkBundle] Rename limiter’s `strategy` to `policy` in XSD
      [VarDumper] Fixed dumping of CutStub
      Fix test
      Change limit argument from string to integer.
      [Messenger] Fix `evaluate()` calls in `WorkerTest`
      [Mailer] STDOUT blocks infinitely under Windows when STDERR is filled
    fabpot committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    bfcfa01 View commit details
    Browse the repository at this point in the history
Loading