Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/psr-http-message-bridge
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.1.6
Choose a base ref
...
head repository: symfony/psr-http-message-bridge
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7.2
Choose a head ref
  • 10 commits
  • 7 files changed
  • 7 contributors

Commits on Jun 20, 2024

  1. Prefix all sprintf() calls

    derrabus committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    ffb7f12 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. chore: CS fixes

    keradus authored and nicolas-grekas committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    55891cd View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Remove redundant check

    seriquynh committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    e464593 View commit details
    Browse the repository at this point in the history
  2. minor #57610 [PsrHttpMessageBridge] Remove a redundant check in HttpF…

    …oundationFactory class (seriquynh)
    
    This PR was merged into the 7.2 branch.
    
    Discussion
    ----------
    
    [PsrHttpMessageBridge] Remove a redundant check in HttpFoundationFactory class
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 7.2
    | Bug fix?      | no
    | New feature?  | no
    | Deprecations? | no
    | Issues        | N/A
    | License       | MIT
    
    `HttpFoundationFactory::createRequest` method receives an implementation of `ServerRequestInterface` and it's `getUri` method must always return a `UriInterface` implementation. So, this check below is redundant.
    
    ```php
    <?php
    $uri = $psrRequest->getUri(); // absolutely is \Psr\Http\Message\UriInterface
    
    if ($uri instanceof UriInterface) { // redundant check
        // Do something
    }
    ```
    
    ### My Concern
    I've checked Symfony roadmap/releases [here](https://symfony.com/releases). And I decided to create a PR to branch 6.4 because:
    - PsrHttpMessage is included in v6.4 (not in 5.4).
    - v6.4 is still maintained (v6.0, v6.1, v6.2 and v6.3 are "End of life" versions).
    - It is not a breaking/major change.
    
    Did I choose branch correctly? If not, please give me more references/posts about how to choose a right branch for a PR.
    
    Commits
    -------
    
    8e7e208149 Remove redundant check
    derrabus committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    6d01a03 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5f48017 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. do not use uniqid() in tests

    updates the remaining tests that were not covered by #57665
    xabbuh committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    321635b View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2024

  1. Configuration menu
    Copy the full SHA
    ae2fde1 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Merge branch '7.1' into 7.2

    * 7.1:
      [Serializer] Remove redundant @internal tags from traceable classes
      Fix conversion of partitioned cookies in the PSR-7 bridge
      [Validator] added Polish translation for units 116-119
      Revert stateless check
      [Console] Fix side-effects from running bash completions
      skip transient Redis integration tests on AppVeyor
    chalasr committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    4475c85 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Merge branch '7.1' into 7.2

    * 7.1:
      Add PR template and auto-close PR on subtree split repositories
    nicolas-grekas committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    162cd84 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. Configuration menu
    Copy the full SHA
    03f2f72 View commit details
    Browse the repository at this point in the history
Loading