minor #58374 Remove useless parent method calls in tests (alexandre-daubois)

fabpot · fabpot · commit b67a2939cbdf · 2024-09-27T10:52:18.000+02:00
This PR was merged into the 7.2 branch.

Discussion
----------

Remove useless parent method calls in tests

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | -
| License       | MIT

The vast majority of tests don't call these parent methods, because they are no op. There are a few places where they are called, let's remove them?

Commits
-------

b54596f604 Remove useless parent method calls in tests
diff --git a/Tests/Generator/Dumper/CompiledUrlGeneratorDumperTest.php b/Tests/Generator/Dumper/CompiledUrlGeneratorDumperTest.php
@@ -33,8 +33,6 @@ class CompiledUrlGeneratorDumperTest extends TestCase
 
     protected function setUp(): void
     {
-        parent::setUp();
-
         $this->routeCollection = new RouteCollection();
         $this->generatorDumper = new CompiledUrlGeneratorDumper($this->routeCollection);
         $this->testTmpFilepath = sys_get_temp_dir().'/php_generator.'.$this->getName().'.php';
@@ -45,8 +43,6 @@ protected function setUp(): void
 
     protected function tearDown(): void
     {
-        parent::tearDown();
-
         @unlink($this->testTmpFilepath);
         @unlink($this->largeTestTmpFilepath);
     }
diff --git a/Tests/Loader/AttributeClassLoaderTest.php b/Tests/Loader/AttributeClassLoaderTest.php
@@ -50,8 +50,6 @@ class AttributeClassLoaderTest extends TestCase
 
     protected function setUp(?string $env = null): void
     {
-        parent::setUp();
-
         $this->loader = new TraceableAttributeClassLoader($env);
     }
 
diff --git a/Tests/Loader/AttributeDirectoryLoaderTest.php b/Tests/Loader/AttributeDirectoryLoaderTest.php
@@ -27,8 +27,6 @@ class AttributeDirectoryLoaderTest extends TestCase
 
     protected function setUp(): void
     {
-        parent::setUp();
-
         $this->classLoader = new TraceableAttributeClassLoader();
         $this->loader = new AttributeDirectoryLoader(new FileLocator(), $this->classLoader);
     }
diff --git a/Tests/Loader/AttributeFileLoaderTest.php b/Tests/Loader/AttributeFileLoaderTest.php
@@ -33,8 +33,6 @@ class AttributeFileLoaderTest extends TestCase
 
     protected function setUp(): void
     {
-        parent::setUp();
-
         $this->classLoader = new TraceableAttributeClassLoader();
         $this->loader = new AttributeFileLoader(new FileLocator(), $this->classLoader);
     }
diff --git a/Tests/Loader/DirectoryLoaderTest.php b/Tests/Loader/DirectoryLoaderTest.php
@@ -26,8 +26,6 @@ class DirectoryLoaderTest extends TestCase
 
     protected function setUp(): void
     {
-        parent::setUp();
-
         $locator = new FileLocator();
         $this->loader = new DirectoryLoader($locator);
         $resolver = new LoaderResolver([
diff --git a/Tests/Matcher/Dumper/CompiledUrlMatcherDumperTest.php b/Tests/Matcher/Dumper/CompiledUrlMatcherDumperTest.php
@@ -28,15 +28,11 @@ class CompiledUrlMatcherDumperTest extends TestCase
 
     protected function setUp(): void
     {
-        parent::setUp();
-
         $this->dumpPath = tempnam(sys_get_temp_dir(), 'sf_matcher_');
     }
 
     protected function tearDown(): void
     {
-        parent::tearDown();
-
         @unlink($this->dumpPath);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,6 @@ class CompiledUrlGeneratorDumperTest extends TestCase`
`33`	`33`
`34`	`34`	`protected function setUp(): void`
`35`	`35`	`{`
`36`		`- parent::setUp();`
`37`		`-`
`38`	`36`	`$this->routeCollection = new RouteCollection();`
`39`	`37`	`$this->generatorDumper = new CompiledUrlGeneratorDumper($this->routeCollection);`
`40`	`38`	`$this->testTmpFilepath = sys_get_temp_dir().'/php_generator.'.$this->getName().'.php';`
`@@ -45,8 +43,6 @@ protected function setUp(): void`
`45`	`43`
`46`	`44`	`protected function tearDown(): void`
`47`	`45`	`{`
`48`		`- parent::tearDown();`
`49`		`-`
`50`	`46`	`@unlink($this->testTmpFilepath);`
`51`	`47`	`@unlink($this->largeTestTmpFilepath);`
`52`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -50,8 +50,6 @@ class AttributeClassLoaderTest extends TestCase`
`50`	`50`
`51`	`51`	`protected function setUp(?string $env = null): void`
`52`	`52`	`{`
`53`		`- parent::setUp();`
`54`		`-`
`55`	`53`	`$this->loader = new TraceableAttributeClassLoader($env);`
`56`	`54`	`}`
`57`	`55`
Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,6 @@ class AttributeDirectoryLoaderTest extends TestCase`
`27`	`27`
`28`	`28`	`protected function setUp(): void`
`29`	`29`	`{`
`30`		`- parent::setUp();`
`31`		`-`
`32`	`30`	`$this->classLoader = new TraceableAttributeClassLoader();`
`33`	`31`	`$this->loader = new AttributeDirectoryLoader(new FileLocator(), $this->classLoader);`
`34`	`32`	`}`
Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,6 @@ class AttributeFileLoaderTest extends TestCase`
`33`	`33`
`34`	`34`	`protected function setUp(): void`
`35`	`35`	`{`
`36`		`- parent::setUp();`
`37`		`-`
`38`	`36`	`$this->classLoader = new TraceableAttributeClassLoader();`
`39`	`37`	`$this->loader = new AttributeFileLoader(new FileLocator(), $this->classLoader);`
`40`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,6 @@ class DirectoryLoaderTest extends TestCase`
`26`	`26`
`27`	`27`	`protected function setUp(): void`
`28`	`28`	`{`
`29`		`- parent::setUp();`
`30`		`-`
`31`	`29`	`$locator = new FileLocator();`
`32`	`30`	`$this->loader = new DirectoryLoader($locator);`
`33`	`31`	`$resolver = new LoaderResolver([`
Original file line number	Diff line number	Diff line change
`@@ -28,15 +28,11 @@ class CompiledUrlMatcherDumperTest extends TestCase`
`28`	`28`
`29`	`29`	`protected function setUp(): void`
`30`	`30`	`{`
`31`		`- parent::setUp();`
`32`		`-`
`33`	`31`	`$this->dumpPath = tempnam(sys_get_temp_dir(), 'sf_matcher_');`
`34`	`32`	`}`
`35`	`33`
`36`	`34`	`protected function tearDown(): void`
`37`	`35`	`{`
`38`		`- parent::tearDown();`
`39`		`-`
`40`	`36`	`@unlink($this->dumpPath);`
`41`	`37`	`}`
`42`	`38`