Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: symfony/security-http
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v4.4.5
Choose a base ref
...
head repository: symfony/security-http
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v4.4.6
Choose a head ref
  • 9 commits
  • 16 files changed
  • 3 contributors

Commits on Mar 15, 2020

  1. Configuration menu
    Copy the full SHA
    b7df8ff View commit details
    Browse the repository at this point in the history
  2. Merge branch '3.4' into 4.4

    * 3.4:
      Add missing dots at the end of exception messages
    fabpot committed Mar 15, 2020
    Configuration menu
    Copy the full SHA
    94ae6e0 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2020

  1. Configuration menu
    Copy the full SHA
    baab66b View commit details
    Browse the repository at this point in the history
  2. Merge branch '3.4' into 4.4

    * 3.4:
      Fix quotes in exception messages
    fabpot committed Mar 16, 2020
    Configuration menu
    Copy the full SHA
    a49d799 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2020

  1. Configuration menu
    Copy the full SHA
    32596f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea48e2d View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2020

  1. bug #36103 [DI] fix preloading script generation (nicolas-grekas)

    This PR was merged into the 4.4 branch.
    
    Discussion
    ----------
    
    [DI] fix preloading script generation
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 4.4
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | -
    | License       | MIT
    | Doc PR        | -
    
    (fabbot failure is a false positive)
    
    On master, we should work on being able to preload more classes (esp. all cache-warmup artifacts).
    
    But for 4.4, this is good enough. Submitted as a bug fix because 1. the current code that deals with preloading kinda-works, but only on "dev" mode... and 2. fixing it provides a nice boost!
    
    Small bench on a hello world:
    - before: 380 req/s
    - after: 580 req/s
    
    That's +50%!
    
    Pro-tip: adding a few `class_exists()` as done in this PR for the classes that are always used in the implementations (e.g. `new Foo()` in the constructor) will help the preload-script generator to work optimally. Without them, it will discover the symbols to preload only if they're found on methods.
    
    Some of those `class_exists()` are mandatory, in relation to anonymous classes and https://bugs.php.net/79349
    
    Commits
    -------
    
    a10fc4da5d [DI] fix preloading script generation
    fabpot committed Mar 18, 2020
    Configuration menu
    Copy the full SHA
    4f613fd View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2020

  1. Configuration menu
    Copy the full SHA
    d964f00 View commit details
    Browse the repository at this point in the history
  2. Merge branch '3.4' into 4.4

    * 3.4:
      [Http Foundation] Fix clear cookie samesite
      [Security] Check if firewall is stateless before checking for session/previous session
      [Form] Support customized intl php.ini settings
      [Security] Remember me: allow to set the samesite cookie flag
      [Debug] fix for PHP 7.3.16+/7.4.4+
      [Validator] Backport translations
      Prevent warning in proc_open()
    nicolas-grekas committed Mar 23, 2020
    Configuration menu
    Copy the full SHA
    dcf596a View commit details
    Browse the repository at this point in the history
Loading