Apply suggestions from code review

OskarStark · web-flow · commit 004e181b250f · 2023-12-20T23:52:30.000+01:00
diff --git a/src/Symfony/Component/VarExporter/Tests/InstantiatorTest.php b/src/Symfony/Component/VarExporter/Tests/InstantiatorTest.php
@@ -35,7 +35,7 @@ public function testFailingInstantiation(string $class)
         Instantiator::instantiate($class);
     }
 
-    public static function provideFailingInstantiation(): iterable
+    public static function provideFailingInstantiation()
     {
         yield ['ReflectionClass'];
         yield ['SplHeap'];
diff --git a/src/Symfony/Component/Yaml/Tests/InlineTest.php b/src/Symfony/Component/Yaml/Tests/InlineTest.php
@@ -291,7 +291,7 @@ public function testParseUnquotedScalarStartingWithScalarIndicator($indicator)
         Inline::parse(sprintf('{ foo: %sfoo }', $indicator));
     }
 
-    public static function getScalarIndicators(): array
+    public static function getScalarIndicators()
     {
         return [['|'], ['>'], ['%']];
     }
@@ -304,7 +304,7 @@ public function testIsHash($array, $expected)
         $this->assertSame($expected, Inline::isHash($array));
     }
 
-    public static function getDataForIsHash(): array
+    public static function getDataForIsHash()
     {
         return [
             [[], false],
@@ -314,7 +314,7 @@ public static function getDataForIsHash(): array
         ];
     }
 
-    public static function getTestsForParse(): array
+    public static function getTestsForParse()
     {
         return [
             ['', ''],
@@ -403,7 +403,7 @@ public static function getTestsForParse(): array
         ];
     }
 
-    public static function getTestsForParseWithMapObjects(): array
+    public static function getTestsForParseWithMapObjects()
     {
         return [
             ['', ''],
@@ -484,7 +484,7 @@ public static function getTestsForParseWithMapObjects(): array
         ];
     }
 
-    public static function getTestsForDump(): array
+    public static function getTestsForDump()
     {
         return [
             ['null', null],
@@ -769,7 +769,7 @@ public function testParseInvalidBinaryData($data, $expectedMessage)
         Inline::parse($data);
     }
 
-    public static function getInvalidBinaryData(): array
+    public static function getInvalidBinaryData()
     {
         return [
             'length not a multiple of four' => ['!!binary "SGVsbG8d29ybGQ="', '/The normalized base64 encoded data \(data without whitespace characters\) length must be a multiple of four \(\d+ bytes given\)/'],
@@ -1022,7 +1022,7 @@ public function testUnquotedExclamationMarkThrows(string $value)
         Inline::parse($value);
     }
 
-    public static function unquotedExclamationMarkThrowsProvider(): array
+    public static function unquotedExclamationMarkThrowsProvider()
     {
         return [
             ['!'],
@@ -1054,7 +1054,7 @@ public function testQuotedExclamationMark($expected, string $value)
     }
 
     // This provider should stay consistent with unquotedExclamationMarkThrowsProvider
-    public static function quotedExclamationMarkProvider(): array
+    public static function quotedExclamationMarkProvider()
     {
         return [
             ['!', '"!"'],

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public function testFailingInstantiation(string $class)`
`35`	`35`	`Instantiator::instantiate($class);`
`36`	`36`	`}`
`37`	`37`
`38`		`- public static function provideFailingInstantiation(): iterable`
	`38`	`+ public static function provideFailingInstantiation()`
`39`	`39`	`{`
`40`	`40`	`yield ['ReflectionClass'];`
`41`	`41`	`yield ['SplHeap'];`
Original file line number	Diff line number	Diff line change
`@@ -291,7 +291,7 @@ public function testParseUnquotedScalarStartingWithScalarIndicator($indicator)`
`291`	`291`	`Inline::parse(sprintf('{ foo: %sfoo }', $indicator));`
`292`	`292`	`}`
`293`	`293`
`294`		`- public static function getScalarIndicators(): array`
	`294`	`+ public static function getScalarIndicators()`
`295`	`295`	`{`
`296`	`296`	`return [['\|'], ['>'], ['%']];`
`297`	`297`	`}`
`@@ -304,7 +304,7 @@ public function testIsHash($array, $expected)`
`304`	`304`	`$this->assertSame($expected, Inline::isHash($array));`
`305`	`305`	`}`
`306`	`306`
`307`		`- public static function getDataForIsHash(): array`
	`307`	`+ public static function getDataForIsHash()`
`308`	`308`	`{`
`309`	`309`	`return [`
`310`	`310`	`[[], false],`
`@@ -314,7 +314,7 @@ public static function getDataForIsHash(): array`
`314`	`314`	`];`
`315`	`315`	`}`
`316`	`316`
`317`		`- public static function getTestsForParse(): array`
	`317`	`+ public static function getTestsForParse()`
`318`	`318`	`{`
`319`	`319`	`return [`
`320`	`320`	`['', ''],`
`@@ -403,7 +403,7 @@ public static function getTestsForParse(): array`
`403`	`403`	`];`
`404`	`404`	`}`
`405`	`405`
`406`		`- public static function getTestsForParseWithMapObjects(): array`
	`406`	`+ public static function getTestsForParseWithMapObjects()`
`407`	`407`	`{`
`408`	`408`	`return [`
`409`	`409`	`['', ''],`
`@@ -484,7 +484,7 @@ public static function getTestsForParseWithMapObjects(): array`
`484`	`484`	`];`
`485`	`485`	`}`
`486`	`486`
`487`		`- public static function getTestsForDump(): array`
	`487`	`+ public static function getTestsForDump()`
`488`	`488`	`{`
`489`	`489`	`return [`
`490`	`490`	`['null', null],`
`@@ -769,7 +769,7 @@ public function testParseInvalidBinaryData($data, $expectedMessage)`
`769`	`769`	`Inline::parse($data);`
`770`	`770`	`}`
`771`	`771`
`772`		`- public static function getInvalidBinaryData(): array`
	`772`	`+ public static function getInvalidBinaryData()`
`773`	`773`	`{`
`774`	`774`	`return [`
`775`	`775`	`'length not a multiple of four' => ['!!binary "SGVsbG8d29ybGQ="', '/The normalized base64 encoded data \(data without whitespace characters\) length must be a multiple of four \(\d+ bytes given\)/'],`
`@@ -1022,7 +1022,7 @@ public function testUnquotedExclamationMarkThrows(string $value)`
`1022`	`1022`	`Inline::parse($value);`
`1023`	`1023`	`}`
`1024`	`1024`
`1025`		`- public static function unquotedExclamationMarkThrowsProvider(): array`
	`1025`	`+ public static function unquotedExclamationMarkThrowsProvider()`
`1026`	`1026`	`{`
`1027`	`1027`	`return [`
`1028`	`1028`	`['!'],`
`@@ -1054,7 +1054,7 @@ public function testQuotedExclamationMark($expected, string $value)`
`1054`	`1054`	`}`
`1055`	`1055`
`1056`	`1056`	`// This provider should stay consistent with unquotedExclamationMarkThrowsProvider`
`1057`		`- public static function quotedExclamationMarkProvider(): array`
	`1057`	`+ public static function quotedExclamationMarkProvider()`
`1058`	`1058`	`{`
`1059`	`1059`	`return [`
`1060`	`1060`	`['!', '"!"'],`