[Serializer] Convert names using denormalize during denormalization

wouterj · wouterj · commit 044caa74762d · 2023-04-18T22:14:24.000+02:00
diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/Php80ReadonlyDummy.php b/src/Symfony/Component/Serializer/Tests/Fixtures/Php80ReadonlyDummy.php
@@ -0,0 +1,20 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Serializer\Tests\Fixtures;
+
+class Php80ReadonlyDummy
+{
+    public function __construct(
+        public readonly string $someValue
+    ) {
+    }
+}
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractNormalizerTest.php
@@ -20,6 +20,7 @@
 use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactory;
 use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactoryInterface;
 use Symfony\Component\Serializer\Mapping\Loader\LoaderChain;
+use Symfony\Component\Serializer\NameConverter\CamelCaseToSnakeCaseNameConverter;
 use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
 use Symfony\Component\Serializer\Normalizer\ObjectNormalizer;
 use Symfony\Component\Serializer\Normalizer\PropertyNormalizer;
@@ -29,6 +30,7 @@
 use Symfony\Component\Serializer\Tests\Fixtures\Dummy;
 use Symfony\Component\Serializer\Tests\Fixtures\NullableConstructorArgumentDummy;
 use Symfony\Component\Serializer\Tests\Fixtures\NullableOptionalConstructorArgumentDummy;
+use Symfony\Component\Serializer\Tests\Fixtures\Php80ReadonlyDummy;
 use Symfony\Component\Serializer\Tests\Fixtures\StaticConstructorDummy;
 use Symfony\Component\Serializer\Tests\Fixtures\StaticConstructorNormalizer;
 use Symfony\Component\Serializer\Tests\Fixtures\VariadicConstructorTypedArgsDummy;
@@ -233,6 +235,19 @@ public function testVariadicSerializationWithPreservingKeys(AbstractNormalizer $
         $this->assertEquals($arr, $dummy->getFoo());
     }
 
+    /**
+     * @requires PHP 8
+     */
+    public function testWithNameConverter()
+    {
+        $normalizer = new ObjectNormalizer(null, new CamelCaseToSnakeCaseNameConverter());
+
+        $object = new Php80ReadonlyDummy('foo');
+        $this->assertEquals(['some_value' => 'foo'], $normalizer->normalize($object));
+        $this->assertEquals($object, $normalizer->denormalize(['some_value' => 'foo'], Php80ReadonlyDummy::class));
+        $this->assertEquals($object, $normalizer->denormalize(['someValue' => 'foo'], Php80ReadonlyDummy::class));
+    }
+
     public static function getNormalizer()
     {
         $extractor = new PhpDocExtractor();
