applied changes suggested by review

wickedOne · wickedOne · commit 06320bb4d3b4 · 2023-11-21T04:37:11.000+01:00
diff --git a/src/Symfony/Component/Translation/Command/TranslationPullCommand.php b/src/Symfony/Component/Translation/Command/TranslationPullCommand.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Translation\Command;
 
+use Psr\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Completion\CompletionInput;
@@ -26,7 +27,6 @@
 use Symfony\Component\Translation\Provider\TranslationProviderCollection;
 use Symfony\Component\Translation\Reader\TranslationReaderInterface;
 use Symfony\Component\Translation\Writer\TranslationWriterInterface;
-use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
 
 /**
  * @author Mathieu Santostefano <msantostefano@protonmail.com>
diff --git a/src/Symfony/Component/Translation/Command/TranslationPushCommand.php b/src/Symfony/Component/Translation/Command/TranslationPushCommand.php
@@ -11,6 +11,7 @@
 
 namespace Symfony\Component\Translation\Command;
 
+use Psr\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\Console\Attribute\AsCommand;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Completion\CompletionInput;
@@ -26,7 +27,6 @@
 use Symfony\Component\Translation\Provider\TranslationProviderCollection;
 use Symfony\Component\Translation\Reader\TranslationReaderInterface;
 use Symfony\Component\Translation\TranslatorBag;
-use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
 
 /**
  * @author Mathieu Santostefano <msantostefano@protonmail.com>
diff --git a/src/Symfony/Component/Translation/Tests/Command/TranslationPullCommandTest.php b/src/Symfony/Component/Translation/Tests/Command/TranslationPullCommandTest.php
@@ -761,13 +761,7 @@ public static function provideEventDispatchingCommands(): \Generator
 
     private function createCommandTester(ProviderInterface $provider, array $locales = ['en'], array $domains = ['messages'], $defaultLocale = 'en', EventDispatcherInterface $dispatcher = null): CommandTester
     {
-        $command = $this->createCommand(
-            provider: $provider,
-            locales: $locales,
-            domains: $domains,
-            defaultLocale: $defaultLocale,
-            dispatcher: $dispatcher
-        );
+        $command = $this->createCommand($provider, $locales, $domains, $defaultLocale, ['loco'], $dispatcher);
         $application = new Application();
         $application->add($command);
 
@@ -785,13 +779,13 @@ private function createCommand(ProviderInterface $provider, array $locales = ['e
         $reader->addLoader('yml', new YamlFileLoader());
 
         return new TranslationPullCommand(
-            providerCollection: $this->getProviderCollection($provider, $providerNames, $locales, $domains),
-            writer: $writer,
-            reader: $reader,
-            defaultLocale: $defaultLocale,
-            transPaths: [$this->translationAppDir.'/translations'],
-            enabledLocales: $locales,
-            eventDispatcher: $dispatcher
+            $this->getProviderCollection($provider, $providerNames, $locales, $domains),
+            $writer,
+            $reader,
+            $defaultLocale,
+            [$this->translationAppDir.'/translations'],
+            $locales,
+            $dispatcher
         );
     }
 }
diff --git a/src/Symfony/Component/Translation/Tests/Command/TranslationPushCommandTest.php b/src/Symfony/Component/Translation/Tests/Command/TranslationPushCommandTest.php
@@ -455,12 +455,7 @@ public static function provideEventDispatchingCommands(): \Generator
 
     private function createCommandTester(ProviderInterface $provider, array $locales = ['en'], array $domains = ['messages'], EventDispatcherInterface $dispatcher = null): CommandTester
     {
-        $command = $this->createCommand(
-            provider: $provider,
-            locales: $locales,
-            domains: $domains,
-            dispatcher: $dispatcher
-        );
+        $command = $this->createCommand($provider, $locales, $domains, ['loco'], $dispatcher);
         $application = new Application();
         $application->add($command);
 
