bug #34198 [HttpClient] Fix perf issue when doing thousands of requests with curl (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 06e745847d18 · 2019-10-31T14:38:12.000+01:00
This PR was merged into the 4.3 branch. Discussion ---------- [HttpClient] Fix perf issue when doing thousands of requests with curl | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Performing while scheduling requests was a terrible idea: it makes buffers fill in memory and requires CPU do deal with the pending list, while all this in dealt with much more efficiently by any response-reading code that comes after. Commits ------- e388b73 [HttpClient] Fix perf issue when doing thousands of requests with curl
diff --git a/src/Symfony/Component/HttpClient/Response/CurlResponse.php b/src/Symfony/Component/HttpClient/Response/CurlResponse.php
@@ -142,7 +142,6 @@ public function __construct(CurlClientState $multi, $ch, array $options = null,
         // Schedule the request in a non-blocking way
         $multi->openHandles[$id] = [$ch, $options];
         curl_multi_add_handle($multi->handle, $ch);
-        self::perform($multi);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -142,7 +142,6 @@ public function __construct(CurlClientState $multi, $ch, array $options = null,`
`142`	`142`	`// Schedule the request in a non-blocking way`
`143`	`143`	`$multi->openHandles[$id] = [$ch, $options];`
`144`	`144`	`curl_multi_add_handle($multi->handle, $ch);`
`145`		`- self::perform($multi);`
`146`	`145`	`}`
`147`	`146`
`148`	`147`	`/**`