[HttpFoundation] Add tests for uncovered sections

alexandre-daubois · alexandre-daubois · commit 08404b204ef2 · 2024-07-18T11:58:54.000+02:00
diff --git a/src/Symfony/Component/HttpFoundation/Tests/InputBagTest.php b/src/Symfony/Component/HttpFoundation/Tests/InputBagTest.php
@@ -98,4 +98,22 @@ public function testFilterArrayWithoutArrayFlagIsDeprecated()
         $this->expectDeprecation('Since symfony/http-foundation 5.1: Filtering an array value with "Symfony\Component\HttpFoundation\InputBag::filter()" without passing the FILTER_REQUIRE_ARRAY or FILTER_FORCE_ARRAY flag is deprecated');
         $bag->filter('foo', \FILTER_VALIDATE_INT);
     }
+
+    public function testAdd()
+    {
+        $bag = new InputBag(['foo' => 'bar']);
+        $bag->add(['baz' => 'qux']);
+
+        $this->assertSame('bar', $bag->get('foo'), '->add() does not remove existing parameters');
+        $this->assertSame('qux', $bag->get('baz'), '->add() adds new parameters');
+    }
+
+    public function testReplace()
+    {
+        $bag = new InputBag(['foo' => 'bar']);
+        $bag->replace(['baz' => 'qux']);
+
+        $this->assertNull($bag->get('foo'), '->replace() removes existing parameters');
+        $this->assertSame('qux', $bag->get('baz'), '->replace() adds new parameters');
+    }
 }
diff --git a/src/Symfony/Component/HttpFoundation/Tests/RateLimiter/AbstractRequestRateLimiterTest.php b/src/Symfony/Component/HttpFoundation/Tests/RateLimiter/AbstractRequestRateLimiterTest.php
@@ -33,6 +33,26 @@ public function testConsume(array $rateLimits, ?RateLimit $expected)
         $this->assertSame($expected, $rateLimiter->consume(new Request()));
     }
 
+    public function testConsumeWithoutLimiterAddSpecialNoLimiter()
+    {
+        $rateLimiter = new MockAbstractRequestRateLimiter([]);
+
+        $this->assertSame(\PHP_INT_MAX, $rateLimiter->consume(new Request())->getLimit());
+    }
+
+    public function testResetLimiters()
+    {
+        $rateLimiter = new MockAbstractRequestRateLimiter([
+            $limiter1 = $this->createMock(LimiterInterface::class),
+            $limiter2 = $this->createMock(LimiterInterface::class),
+        ]);
+
+        $limiter1->expects($this->once())->method('reset');
+        $limiter2->expects($this->once())->method('reset');
+
+        $rateLimiter->reset(new Request());
+    }
+
     public static function provideRateLimits()
     {
         $now = new \DateTimeImmutable();
