bug #33045 Make HttpClientTestCase compatible with PHPUnit8 (jderusse)

nicolas-grekas · nicolas-grekas · commit 0abd64bb2b5b · 2019-08-08T12:04:39.000+02:00
This PR was merged into the 4.3 branch. Discussion ---------- Make HttpClientTestCase compatible with PHPUnit8 | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA the abstract class `HttpClientTestCase` may be extends by end user and execute by both PHPUnit 8 and bellow. Adding a return typehint on it will force all users extending it to add it too and would be a BC Break. Note. I don't know how to trigger a deprecation here and help user to add it. Commits ------- 55daf15 Fix compatibility with PHPUnit 8
diff --git a/src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php b/src/Symfony/Contracts/HttpClient/Test/HttpClientTestCase.php
@@ -26,7 +26,7 @@ abstract class HttpClientTestCase extends TestCase
 {
     private static $server;
 
-    public static function setUpBeforeClass()
+    public static function setUpBeforeClass(): void
     {
         TestHttpServer::start();
     }

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ abstract class HttpClientTestCase extends TestCase`
`26`	`26`	`{`
`27`	`27`	`private static $server;`
`28`	`28`
`29`		`- public static function setUpBeforeClass()`
	`29`	`+ public static function setUpBeforeClass(): void`
`30`	`30`	`{`
`31`	`31`	`TestHttpServer::start();`
`32`	`32`	`}`