minor #27406 [Security] Add missing upgrade note about GuardAuthenticationListener-related deprecation (DonCallisto)

fabpot · fabpot · commit 1356fe7b58f4 · 2018-05-31T09:38:11.000+02:00
This PR was merged into the 3.4 branch. Discussion ---------- [Security] Add missing upgrade note about GuardAuthenticationListener-related deprecation | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | | Fixed tickets | | License | MIT | Doc PR | This https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Security/Guard/Firewall/GuardAuthenticationListener.php#L127 was not reported. Commits ------- c09ca94 Update UPGRADE-4.0.md
diff --git a/UPGRADE-3.4.md b/UPGRADE-3.4.md
@@ -344,6 +344,9 @@ Security
 
  * The `GuardAuthenticatorInterface` has been deprecated and will be removed in 4.0.
    Use `AuthenticatorInterface` instead.
+   
+ * When extending `AbstractGuardAuthenticator` it's deprecated to return `null` from `getCredentials()`.
+   Return `false` from `supports()` if no credentials available.
 
 SecurityBundle
 --------------
diff --git a/UPGRADE-4.0.md b/UPGRADE-4.0.md
@@ -758,6 +758,9 @@ Security
 
  * The `GuardAuthenticatorInterface` interface has been removed.
    Use `AuthenticatorInterface` instead.
+   
+ * When extending `AbstractGuardAuthenticator` getCredentials() cannot return 
+   `null` anymore, return false from `supports()` if no credentials available instead.
 
 SecurityBundle
 --------------
diff --git a/src/Symfony/Component/Security/CHANGELOG.md b/src/Symfony/Component/Security/CHANGELOG.md
@@ -16,6 +16,8 @@ CHANGELOG
  * deprecated HTTP digest authentication
  * Added a new password encoder for the Argon2i hashing algorithm
  * deprecated `GuardAuthenticatorInterface` in favor of `AuthenticatorInterface`
+ * deprecated to return `null` from `getCredentials()` in classes that extend 
+   `AbstractGuardAuthenticator`. Return `false` from `supports()` instead.
 
 3.3.0
 -----
