bug #27209 [Workflow] add is deprecated since Symfony 4.1. Use addWorkflow() instead (xkobal)

fabpot · fabpot · commit 1403112de189 · 2018-05-09T17:27:38.000+02:00
This PR was squashed before being merged into the 4.1 branch (closes #27209). Discussion ---------- [Workflow] add is deprecated since Symfony 4.1. Use addWorkflow() instead | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #... | License | MIT | Doc PR | symfony/symfony-docs#...  Commits ------- ffa5d1c [Workflow] add is deprecated since Symfony 4.1. Use addWorkflow() instead
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -573,10 +573,10 @@ private function registerWorkflowConfiguration(array $config, ContainerBuilder $
                 foreach ($workflow['supports'] as $supportedClassName) {
                     $strategyDefinition = new Definition(Workflow\SupportStrategy\InstanceOfSupportStrategy::class, array($supportedClassName));
                     $strategyDefinition->setPublic(false);
-                    $registryDefinition->addMethodCall('add', array(new Reference($workflowId), $strategyDefinition));
+                    $registryDefinition->addMethodCall('addWorkflow', array(new Reference($workflowId), $strategyDefinition));
                 }
             } elseif (isset($workflow['support_strategy'])) {
-                $registryDefinition->addMethodCall('add', array(new Reference($workflowId), new Reference($workflow['support_strategy'])));
+                $registryDefinition->addMethodCall('addWorkflow', array(new Reference($workflowId), new Reference($workflow['support_strategy'])));
             }
 
             // Enable the AuditTrail
diff --git a/src/Symfony/Bundle/FrameworkBundle/composer.json b/src/Symfony/Bundle/FrameworkBundle/composer.json
@@ -51,7 +51,7 @@
         "symfony/templating": "~3.4|~4.0",
         "symfony/validator": "^4.1",
         "symfony/var-dumper": "~3.4|~4.0",
-        "symfony/workflow": "~3.4|~4.0",
+        "symfony/workflow": "^4.1",
         "symfony/yaml": "~3.4|~4.0",
         "symfony/property-info": "~3.4|~4.0",
         "symfony/lock": "~3.4|~4.0",
@@ -72,7 +72,7 @@
         "symfony/stopwatch": "<3.4",
         "symfony/translation": "<3.4",
         "symfony/validator": "<4.1",
-        "symfony/workflow": "<3.4"
+        "symfony/workflow": "<4.1"
     },
     "suggest": {
         "ext-apcu": "For best performance of the system caches",

Original file line number	Diff line number	Diff line change
`@@ -573,10 +573,10 @@ private function registerWorkflowConfiguration(array $config, ContainerBuilder $`
`573`	`573`	`foreach ($workflow['supports'] as $supportedClassName) {`
`574`	`574`	`$strategyDefinition = new Definition(Workflow\SupportStrategy\InstanceOfSupportStrategy::class, array($supportedClassName));`
`575`	`575`	`$strategyDefinition->setPublic(false);`
`576`		`- $registryDefinition->addMethodCall('add', array(new Reference($workflowId), $strategyDefinition));`
	`576`	`+ $registryDefinition->addMethodCall('addWorkflow', array(new Reference($workflowId), $strategyDefinition));`
`577`	`577`	`}`
`578`	`578`	`} elseif (isset($workflow['support_strategy'])) {`
`579`		`- $registryDefinition->addMethodCall('add', array(new Reference($workflowId), new Reference($workflow['support_strategy'])));`
	`579`	`+ $registryDefinition->addMethodCall('addWorkflow', array(new Reference($workflowId), new Reference($workflow['support_strategy'])));`
`580`	`580`	`}`
`581`	`581`
`582`	`582`	`// Enable the AuditTrail`