Get rid of constants

xvilo · xvilo · commit 184f35e730a1 · 2024-06-22T12:54:30.000+02:00
diff --git a/src/Symfony/Component/Messenger/Command/StatsCommand.php b/src/Symfony/Component/Messenger/Command/StatsCommand.php
@@ -29,12 +29,6 @@
 #[AsCommand(name: 'messenger:stats', description: 'Show the message count for one or more transports')]
 class StatsCommand extends Command
 {
-    public const OUTPUT_FORMAT_TEXT = 'text';
-
-    public const OUTPUT_FORMAT_JSON = 'json';
-
-    public const ALL_OUTPUT_FORMATS = [self::OUTPUT_FORMAT_TEXT, self::OUTPUT_FORMAT_JSON];
-
     public function __construct(
         private ContainerInterface $transportLocator,
         private array $transportNames = [],
@@ -44,10 +38,10 @@ public function __construct(
 
     protected function configure(): void
     {
-        $outputFormats = implode(', ', self::ALL_OUTPUT_FORMATS);
+        $outputFormats = implode(', ', $this->getAvailableFormatOptions());
         $this
             ->addArgument('transport_names', InputArgument::IS_ARRAY | InputArgument::OPTIONAL, 'List of transports\' names')
-            ->addOption('format', '', InputOption::VALUE_REQUIRED, 'The output format, e.g.: '.$outputFormats, self::OUTPUT_FORMAT_TEXT, self::ALL_OUTPUT_FORMATS)
+            ->addOption('format', '', InputOption::VALUE_REQUIRED, 'The output format, e.g.: '.$outputFormats, 'text', $this->getAvailableFormatOptions())
             ->setHelp(<<<EOF
 The <info>%command.name%</info> command counts the messages for all the transports:
 
@@ -70,11 +64,10 @@ protected function execute(InputInterface $input, OutputInterface $output): int
     {
         $io = new SymfonyStyle($input, $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output);
 
-        $format = match ($input->getOption('format')) {
-            self::OUTPUT_FORMAT_TEXT,
-            self::OUTPUT_FORMAT_JSON => $input->getOption('format'),
-            default => throw new InvalidArgumentException('Invalid output format.'),
-        };
+        $format = $input->getOption('format');
+        if (!\in_array($format, $this->getAvailableFormatOptions(), true)) {
+            throw new InvalidArgumentException('Invalid output format.');
+        }
 
         $transportNames = $this->transportNames;
         if ($input->getArgument('transport_names')) {
@@ -101,8 +94,8 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         }
 
         match ($format) {
-            self::OUTPUT_FORMAT_TEXT => $this->outputText($io, $outputTable, $uncountableTransports),
-            self::OUTPUT_FORMAT_JSON => $this->outputJson($io, $outputTable, $uncountableTransports),
+            'text' => $this->outputText($io, $outputTable, $uncountableTransports),
+            'json' => $this->outputJson($io, $outputTable, $uncountableTransports),
         };
 
         return 0;
@@ -134,8 +127,14 @@ private function outputJson(SymfonyStyle $io, array $outputTable, array $uncount
     private function formatSupportsWarnings(string $format): bool
     {
         return match ($format) {
-            self::OUTPUT_FORMAT_TEXT => true,
-            self::OUTPUT_FORMAT_JSON => false,
+            'text' => true,
+            'json' => false,
         };
     }
+
+    /** @return string[] */
+    private function getAvailableFormatOptions(): array
+    {
+        return ['text', 'json'];
+    }
 }
