feature #60103 [Console] Mark AsCommand attribute as @final (Somrlik, GromNaN)

GromNaN · GromNaN · commit 1a8b82e5dfd4 · 2025-04-01T10:41:13.000+02:00
This PR was merged into the 7.3 branch. Discussion ---------- [Console] Mark `AsCommand` attribute as ``@final`` | Q | A | ------------- | --- | Branch? | 7.3 | Bug fix? | yes | New feature? | no | Deprecations? | yes | License | MIT `AsCommand` attribute doesn't work as expected when extended and probably should be declared as final. In order to not break BC and trigger a deprecation warning, I marked the attribute as ``@final`` as per suggestions in previous PR. Superseeds #60066 as I closed it accidentally, sorry for confusion 😕 Commits ------- 1db80a5 [Console] Mark `AsCommand` attribute as ``@final``
diff --git a/UPGRADE-7.3.md b/UPGRADE-7.3.md
@@ -40,6 +40,7 @@ Console
    ```
 
  * Deprecate methods `Command::getDefaultName()` and `Command::getDefaultDescription()` in favor of the `#[AsCommand]` attribute
+ * `#[AsCommand]` attribute is now marked as `@final`; you should use separate attributes to add more logic to commands
 
 DependencyInjection
 -------------------
diff --git a/src/Symfony/Component/Console/Attribute/AsCommand.php b/src/Symfony/Component/Console/Attribute/AsCommand.php
@@ -13,6 +13,8 @@
 
 /**
  * Service tag to autoconfigure commands.
+ *
+ * @final since Symfony 7.3
  */
 #[\Attribute(\Attribute::TARGET_CLASS)]
 class AsCommand
diff --git a/src/Symfony/Component/Console/CHANGELOG.md b/src/Symfony/Component/Console/CHANGELOG.md
@@ -13,6 +13,7 @@ CHANGELOG
  * Add support for Markdown format in `Table`
  * Add support for `LockableTrait` in invokable commands
  * Deprecate returning a non-integer value from a `\Closure` function set via `Command::setCode()`
+ * Mark `#[AsCommand]` attribute as `@final`
 
 7.2
 ---
