minor #40735 [Notifier] LightSMS duplicated $errorCode variable fix (StaffNowa)

Nyholm · Nyholm · commit 1d8ad1d2ceb7 · 2021-04-08T15:38:09.000+02:00
This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Notifier] LightSMS duplicated $errorCode variable fix | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #40712, #40733 | License | MIT | Doc PR | - Removed duplicated variable $errorCode. Many thanks for: @OskarStark, @jderusse and special thanks for @chalasr for fast rebase course at night :))) Commits ------- 867769e [Notifier] LightSMS duplicated $errorCode variable fix
diff --git a/src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php b/src/Symfony/Component/Notifier/Bridge/LightSms/LightSmsTransport.php
@@ -124,8 +124,8 @@ protected function doSend(MessageInterface $message): SentMessage
 
         $content = $response->toArray(false);
 
-        if (0 !== (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1) {
-            $errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1;
+        $errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1;
+        if (0 !== $errorCode) {
             if (-1 === $errorCode) {
                 throw new TransportException('Unable to send the SMS.', $response);
             }

Original file line number	Diff line number	Diff line change
`@@ -124,8 +124,8 @@ protected function doSend(MessageInterface $message): SentMessage`
`124`	`124`
`125`	`125`	`$content = $response->toArray(false);`
`126`	`126`
`127`		`- if (0 !== (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1) {`
`128`		`- $errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1;`
	`127`	`+ $errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1;`
	`128`	`+ if (0 !== $errorCode) {`
`129`	`129`	`if (-1 === $errorCode) {`
`130`	`130`	`throw new TransportException('Unable to send the SMS.', $response);`
`131`	`131`	`}`