Remove COMMIT

Nyholm · Nyholm · commit 24c2a634b55b · 2021-03-02T11:33:48.000+01:00
diff --git a/src/Symfony/Component/Messenger/Bridge/Doctrine/Tests/Transport/PostgreSqlConnectionTest.php b/src/Symfony/Component/Messenger/Bridge/Doctrine/Tests/Transport/PostgreSqlConnectionTest.php
@@ -59,6 +59,9 @@ public function testGetExtraSetupSql()
          */
         $this->assertStringContainsString('BEGIN;', $sql);
         $this->assertStringContainsString('CREATE TRIGGER', $sql);
+
+        // We MUST NOT commit, that will mess with the PDO in PHP 8
+        $this->assertStringNotContainsString('COMMIT;', $sql);
     }
 
     public function testGetExtraSetupSqlWrongTable()
diff --git a/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/PostgreSqlConnection.php b/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/PostgreSqlConnection.php
@@ -124,7 +124,6 @@ private function getTriggerSql(): array
             // register trigger
             sprintf('DROP TRIGGER IF EXISTS notify_trigger ON %s;', $this->configuration['table_name']),
             sprintf('CREATE TRIGGER notify_trigger AFTER INSERT OR UPDATE ON %1$s FOR EACH ROW EXECUTE PROCEDURE notify_%1$s();', $this->configuration['table_name']),
-            'COMMIT;',
         ];
     }
 

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,9 @@ public function testGetExtraSetupSql()`
`59`	`59`	`*/`
`60`	`60`	`$this->assertStringContainsString('BEGIN;', $sql);`
`61`	`61`	`$this->assertStringContainsString('CREATE TRIGGER', $sql);`
	`62`	`+`
	`63`	`+ // We MUST NOT commit, that will mess with the PDO in PHP 8`
	`64`	`+ $this->assertStringNotContainsString('COMMIT;', $sql);`
`62`	`65`	`}`
`63`	`66`
`64`	`67`	`public function testGetExtraSetupSqlWrongTable()`
Original file line number	Diff line number	Diff line change
`@@ -124,7 +124,6 @@ private function getTriggerSql(): array`
`124`	`124`	`// register trigger`
`125`	`125`	`sprintf('DROP TRIGGER IF EXISTS notify_trigger ON %s;', $this->configuration['table_name']),`
`126`	`126`	`sprintf('CREATE TRIGGER notify_trigger AFTER INSERT OR UPDATE ON %1$s FOR EACH ROW EXECUTE PROCEDURE notify_%1$s();', $this->configuration['table_name']),`
`127`		`- 'COMMIT;',`
`128`	`127`	`];`
`129`	`128`	`}`
`130`	`129`