minor #61452 Remove direct access to internal properties cross-components (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 254ae09741ae · 2025-08-18T14:39:42.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- Remove direct access to internal properties cross-components | Q | A | ------------- | --- | Branch? | 7.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Commits ------- 1d83980 Remove direct access to internal properties cross-components
diff --git a/src/Symfony/Bridge/Doctrine/Tests/Validator/DoctrineLoaderTest.php b/src/Symfony/Bridge/Doctrine/Tests/Validator/DoctrineLoaderTest.php
@@ -214,7 +214,7 @@ public function testClassNoAutoMapping()
 
         /** @var PropertyMetadata[] $autoMappingExplicitlyEnabledMetadata */
         $autoMappingExplicitlyEnabledMetadata = $classMetadata->getPropertyMetadata('autoMappingExplicitlyEnabled');
-        $this->assertCount(1, $autoMappingExplicitlyEnabledMetadata[0]->constraints);
+        $this->assertCount(1, $autoMappingExplicitlyEnabledMetadata[0]->getConstraints());
         $this->assertSame(AutoMappingStrategy::ENABLED, $autoMappingExplicitlyEnabledMetadata[0]->getAutoMappingStrategy());
     }
 }
diff --git a/src/Symfony/Component/Form/Tests/Extension/Validator/ValidatorExtensionTest.php b/src/Symfony/Component/Form/Tests/Extension/Validator/ValidatorExtensionTest.php
@@ -42,8 +42,8 @@ public function test2Dot5ValidationApi()
         $this->assertCount(1, $metadata->getConstraints());
         $this->assertInstanceOf(FormConstraint::class, $metadata->getConstraints()[0]);
 
-        $this->assertSame(CascadingStrategy::NONE, $metadata->cascadingStrategy);
-        $this->assertSame(TraversalStrategy::NONE, $metadata->traversalStrategy);
+        $this->assertSame(CascadingStrategy::NONE, $metadata->getCascadingStrategy());
+        $this->assertSame(TraversalStrategy::NONE, $metadata->getTraversalStrategy());
         $this->assertCount(0, $metadata->getPropertyMetadata('children'));
     }
 }
diff --git a/src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordTest.php b/src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordTest.php
@@ -42,20 +42,20 @@ public static function provideServiceValidatedConstraints(): iterable
         $metadata = new ClassMetadata(UserPasswordDummy::class);
         self::assertTrue((new AttributeLoader())->loadClassMetadata($metadata));
 
-        yield 'attribute' => [$metadata->properties['b']->constraints[0]];
+        yield 'attribute' => [$metadata->getPropertyMetadata('b')[0]->getConstraints()[0]];
     }
 
     public function testAttributes()
     {
         $metadata = new ClassMetadata(UserPasswordDummy::class);
         self::assertTrue((new AttributeLoader())->loadClassMetadata($metadata));
 
-        [$bConstraint] = $metadata->properties['b']->getConstraints();
+        [$bConstraint] = $metadata->getPropertyMetadata('b')[0]->getConstraints();
         self::assertSame('myMessage', $bConstraint->message);
         self::assertSame(['Default', 'UserPasswordDummy'], $bConstraint->groups);
         self::assertNull($bConstraint->payload);
 
-        [$cConstraint] = $metadata->properties['c']->getConstraints();
+        [$cConstraint] = $metadata->getPropertyMetadata('c')[0]->getConstraints();
         self::assertSame(['my_group'], $cConstraint->groups);
         self::assertSame('some attached data', $cConstraint->payload);
     }

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ public function testClassNoAutoMapping()`
`214`	`214`
`215`	`215`	`/** @var PropertyMetadata[] $autoMappingExplicitlyEnabledMetadata */`
`216`	`216`	`$autoMappingExplicitlyEnabledMetadata = $classMetadata->getPropertyMetadata('autoMappingExplicitlyEnabled');`
`217`		`- $this->assertCount(1, $autoMappingExplicitlyEnabledMetadata[0]->constraints);`
	`217`	`+ $this->assertCount(1, $autoMappingExplicitlyEnabledMetadata[0]->getConstraints());`
`218`	`218`	`$this->assertSame(AutoMappingStrategy::ENABLED, $autoMappingExplicitlyEnabledMetadata[0]->getAutoMappingStrategy());`
`219`	`219`	`}`
`220`	`220`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,8 +42,8 @@ public function test2Dot5ValidationApi()`
`42`	`42`	`$this->assertCount(1, $metadata->getConstraints());`
`43`	`43`	`$this->assertInstanceOf(FormConstraint::class, $metadata->getConstraints()[0]);`
`44`	`44`
`45`		`- $this->assertSame(CascadingStrategy::NONE, $metadata->cascadingStrategy);`
`46`		`- $this->assertSame(TraversalStrategy::NONE, $metadata->traversalStrategy);`
	`45`	`+ $this->assertSame(CascadingStrategy::NONE, $metadata->getCascadingStrategy());`
	`46`	`+ $this->assertSame(TraversalStrategy::NONE, $metadata->getTraversalStrategy());`
`47`	`47`	`$this->assertCount(0, $metadata->getPropertyMetadata('children'));`
`48`	`48`	`}`
`49`	`49`	`}`