[Console] Added suggestions for missing packages

przemyslaw-bogusz · przemyslaw-bogusz · commit 268e80f8550a · 2019-01-12T23:33:38.000+01:00
diff --git a/src/Symfony/Component/Console/Application.php b/src/Symfony/Component/Console/Application.php
@@ -62,6 +62,25 @@
  */
 class Application
 {
+    const SUGGESTED_PACKAGES = [
+        'doctrine' => [
+            'Doctrine ORM',
+            'symfony/orm-pack',
+        ],
+        'generate' => [
+            'SensioGeneratorBundle',
+            'sensio/generator-bundle',
+        ],
+        'make' => [
+            'MakerBundle',
+            'symfony/maker-bundle --dev',
+        ],
+        'server' => [
+            'Symfony Web Server',
+            'symfony/web-server-bundle --dev',
+        ],
+    ];
+
     private $commands = array();
     private $wantHelps = false;
     private $runningCommand;
@@ -563,6 +582,8 @@ public function findNamespace($namespace)
         $namespaces = preg_grep('{^'.$expr.'}', $allNamespaces);
 
         if (empty($namespaces)) {
+            $this->suggestPackage($namespace);
+
             $message = sprintf('There are no commands defined in the "%s" namespace.', $namespace);
 
             if ($alternatives = $this->findAlternatives($namespace, $allNamespaces)) {
@@ -1171,4 +1192,24 @@ private function init()
             $this->add($command);
         }
     }
+
+    /**
+     * Suggests a package, that should be installed via composer,
+     * if the package is missing, and the provided namespace can be mapped to a Symfony bundle.
+     *
+     * @param string $namespace A namespace to search for
+     *
+     * @return void
+     *
+     * @throws NamespaceNotFoundException When namespace is mapped to a Symfony bundle
+     */
+    private function suggestPackage($namespace) {
+        if (isset(self::SUGGESTED_PACKAGES[$namespace])) {
+            $suggestion = self::SUGGESTED_PACKAGES[$namespace];
+
+            $message = sprintf("It seems that you are trying to run a command from '%s' bundle/package, but you do not have it installed. You may try installing the missing bundle/package by running:\n\n    composer require %s", $suggestion[0], $suggestion[1]);
+
+            throw  new NamespaceNotFoundException($message);
+        }
+    }
 }
diff --git a/src/Symfony/Component/Console/Tests/ApplicationTest.php b/src/Symfony/Component/Console/Tests/ApplicationTest.php
@@ -304,6 +304,16 @@ public function testFindInvalidNamespace()
         $application->findNamespace('bar');
     }
 
+    /**
+     * @expectedException        \Symfony\Component\Console\Exception\NamespaceNotFoundException
+     * @expectedExceptionMessageRegExp /^It seems that you are trying to run a command from .+/
+     */
+    public function testFindSuggestedPackage()
+    {
+        $application = new Application();
+        $application->findNamespace('make');
+    }
+
     /**
      * @expectedException        \Symfony\Component\Console\Exception\CommandNotFoundException
      * @expectedExceptionMessage Command "foo1" is not defined
