Execute redis tests with github actions

jakzal · jakzal · commit 26ca70032bfa · 2020-04-30T21:46:15.000+01:00
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -0,0 +1,52 @@
+name: Tests
+
+on:
+    push:
+    pull_request:
+
+jobs:
+
+    redis-tests:
+        name: Redis tests
+        runs-on: ubuntu-latest
+        strategy:
+            matrix:
+                php: [7.2, 7.3, 7.4]
+        services:
+            redis:
+                image: redis
+                ports:
+                    - 6379:6379
+            redis-cluster:
+                image: grokzen/redis-cluster:4.0.8
+                ports:
+                    - 7000:7000
+                    - 7001:7001
+                    - 7002:7002
+                    - 7003:7003
+                    - 7004:7004
+                    - 7005:7005
+        container:
+            image: jakzal/phpqa:php${{ matrix.php }}
+        steps:
+            - uses: actions/checkout@v2
+            # Install system dependencies
+            - run: 'apt-get update && apt-get install -y autoconf file g++ gcc libc-dev pkg-config re2c'
+            - run: 'pecl install redis && docker-php-ext-enable redis'
+            # Configure PHP & Composer
+            - run: echo memory_limit = -1 >> /usr/local/etc/php/conf.d/custom.ini
+            - run: '[ -d ~/.composer ] || mkdir ~/.composer'
+            - run: cp .github/composer-config.json ~/.composer/config.json
+            # Configure the build
+            - run: echo "::set-env name=SYMFONY_VERSION::$(cat composer.json | grep '^ *\"dev-master\". *\"[1-9]' | grep -o '[0-9.]*')"
+            - run: echo "::set-env name=COMPOSER_ROOT_VERSION::$SYMFONY_VERSION.x-dev"
+            # Install dependencies
+            - run: composer global require --no-progress --no-scripts --no-plugins symfony/flex dev-master
+            - run: composer update --no-progress --no-suggest --ansi
+            - run: ./phpunit install
+            # Run tests
+            - run: ./phpunit --group redis --verbose
+              env:
+                  REDIS_HOST: redis
+                  REDIS_CLUSTER_HOSTS: 'redis-cluster:7000 redis-cluster:7001 redis-cluster:7002 redis-cluster:7003 redis-cluster:7004 redis-cluster:7005'
+
diff --git a/.travis.yml b/.travis.yml
@@ -40,7 +40,6 @@ cache:
 services:
     - memcached
     - mongodb
-    - redis-server
     - docker
 
 before_install:
@@ -52,12 +51,6 @@ before_install:
       sudo rm /etc/apt/sources.list.d/mongodb-3.4.list
       sudo apt update
 
-    - |
-      # Start Redis cluster
-      docker pull grokzen/redis-cluster:4.0.8
-      docker run -d -p 7000:7000 -p 7001:7001 -p 7002:7002 -p 7003:7003 -p 7004:7004 -p 7005:7005 --name redis-cluster grokzen/redis-cluster:4.0.8
-      export REDIS_CLUSTER_HOSTS='localhost:7000 localhost:7001 localhost:7002 localhost:7003 localhost:7004 localhost:7005'
-
     - |
       # General configuration
       set -e
@@ -67,7 +60,7 @@ before_install:
       [ -d ~/.composer ] || mkdir ~/.composer
       cp .github/composer-config.json ~/.composer/config.json
       export PHPUNIT=$(readlink -f ./phpunit)
-      export PHPUNIT_X="$PHPUNIT --exclude-group tty,benchmark,intl-data"
+      export PHPUNIT_X="$PHPUNIT --exclude-group tty,benchmark,intl-data,redis"
       export COMPOSER_UP='composer update --no-progress --no-suggest --ansi'
       export COMPONENTS=$(find src/Symfony -mindepth 3 -type f -name phpunit.xml.dist -printf '%h\n' | sort)
       find ~/.phpenv -name xdebug.ini -delete
@@ -157,7 +150,6 @@ before_install:
           echo opcache.enable_cli = 1 >> $INI
           echo hhvm.jit = 0 >> $INI
           echo apc.enable_cli = 1 >> $INI
-          echo extension = redis.so >> $INI
           echo extension = memcached.so >> $INI
           if [[ $PHP = 5.* ]]; then
               echo extension = memcache.so >> $INI
@@ -297,7 +289,7 @@ install:
               echo "$COMPONENTS" | xargs -n1 -I{} tar --append -f ~/php-ext/composer-lowest.lock.tar {}/composer.lock
           elif [[ $PHP = hhvm* ]]; then
               rm src/Symfony/Bridge/PhpUnit -Rf
-              $PHPUNIT --exclude-group no-hhvm,benchmark,intl-data
+              $PHPUNIT --exclude-group no-hhvm,benchmark,intl-data,redis
           else
               echo "$COMPONENTS" | parallel --gnu "tfold {} $PHPUNIT_X {}"
               tfold src/Symfony/Component/Console.tty $PHPUNIT src/Symfony/Component/Console --group tty
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/CachePoolsTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/Functional/CachePoolsTest.php
@@ -24,6 +24,7 @@ public function testCachePools()
 
     /**
      * @requires extension redis
+     * @group redis
      */
     public function testRedisCachePools()
     {
@@ -49,6 +50,7 @@ public function testRedisCachePools()
 
     /**
      * @requires extension redis
+     * @group redis
      */
     public function testRedisCustomCachePools()
     {
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/PredisAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/PredisAdapterTest.php
@@ -14,6 +14,9 @@
 use Predis\Connection\StreamConnection;
 use Symfony\Component\Cache\Adapter\RedisAdapter;
 
+/**
+ * @group redis
+ */
 class PredisAdapterTest extends AbstractRedisAdapterTest
 {
     public static function setUpBeforeClass()
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/PredisClusterAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/PredisClusterAdapterTest.php
@@ -11,6 +11,9 @@
 
 namespace Symfony\Component\Cache\Tests\Adapter;
 
+/**
+ * @group redis
+ */
 class PredisClusterAdapterTest extends AbstractRedisAdapterTest
 {
     public static function setUpBeforeClass()
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/PredisRedisClusterAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/PredisRedisClusterAdapterTest.php
@@ -11,6 +11,9 @@
 
 namespace Symfony\Component\Cache\Tests\Adapter;
 
+/**
+ * @group redis
+ */
 class PredisRedisClusterAdapterTest extends AbstractRedisAdapterTest
 {
     public static function setUpBeforeClass()
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/RedisAdapterTest.php
@@ -15,6 +15,9 @@
 use Symfony\Component\Cache\Adapter\RedisAdapter;
 use Symfony\Component\Cache\Traits\RedisProxy;
 
+/**
+ * @group redis
+ */
 class RedisAdapterTest extends AbstractRedisAdapterTest
 {
     public static function setUpBeforeClass()
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/RedisArrayAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/RedisArrayAdapterTest.php
@@ -11,6 +11,9 @@
 
 namespace Symfony\Component\Cache\Tests\Adapter;
 
+/**
+ * @group redis
+ */
 class RedisArrayAdapterTest extends AbstractRedisAdapterTest
 {
     public static function setUpBeforeClass()
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/RedisClusterAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/RedisClusterAdapterTest.php
@@ -11,6 +11,9 @@
 
 namespace Symfony\Component\Cache\Tests\Adapter;
 
+/**
+ * @group redis
+ */
 class RedisClusterAdapterTest extends AbstractRedisAdapterTest
 {
     public static function setUpBeforeClass()
diff --git a/src/Symfony/Component/Cache/Tests/Simple/RedisArrayCacheTest.php b/src/Symfony/Component/Cache/Tests/Simple/RedisArrayCacheTest.php
@@ -11,6 +11,9 @@
 
 namespace Symfony\Component\Cache\Tests\Simple;
 
+/**
+ * @group redis
+ */
 class RedisArrayCacheTest extends AbstractRedisCacheTest
 {
     public static function setUpBeforeClass()
diff --git a/src/Symfony/Component/Cache/Tests/Simple/RedisCacheTest.php b/src/Symfony/Component/Cache/Tests/Simple/RedisCacheTest.php
@@ -13,6 +13,9 @@
 
 use Symfony\Component\Cache\Simple\RedisCache;
 
+/**
+ * @group redis
+ */
 class RedisCacheTest extends AbstractRedisCacheTest
 {
     public static function setUpBeforeClass()
diff --git a/src/Symfony/Component/Cache/Tests/Simple/RedisClusterCacheTest.php b/src/Symfony/Component/Cache/Tests/Simple/RedisClusterCacheTest.php
@@ -11,6 +11,9 @@
 
 namespace Symfony\Component\Cache\Tests\Simple;
 
+/**
+ * @group redis
+ */
 class RedisClusterCacheTest extends AbstractRedisCacheTest
 {
     public static function setUpBeforeClass()
diff --git a/src/Symfony/Component/Lock/Tests/Store/PredisStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/PredisStoreTest.php
@@ -13,6 +13,7 @@
 
 /**
  * @author Jérémy Derussé <jeremy@derusse.com>
+ * @group redis
  */
 class PredisStoreTest extends AbstractRedisStoreTest
 {
diff --git a/src/Symfony/Component/Lock/Tests/Store/RedisArrayStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/RedisArrayStoreTest.php
@@ -15,6 +15,7 @@
  * @author Jérémy Derussé <jeremy@derusse.com>
  *
  * @requires extension redis
+ * @group redis
  */
 class RedisArrayStoreTest extends AbstractRedisStoreTest
 {
diff --git a/src/Symfony/Component/Lock/Tests/Store/RedisClusterStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/RedisClusterStoreTest.php
@@ -15,6 +15,7 @@
  * @author Jérémy Derussé <jeremy@derusse.com>
  *
  * @requires extension redis
+ * @group redis
  */
 class RedisClusterStoreTest extends AbstractRedisStoreTest
 {
diff --git a/src/Symfony/Component/Lock/Tests/Store/RedisStoreTest.php b/src/Symfony/Component/Lock/Tests/Store/RedisStoreTest.php
@@ -15,6 +15,7 @@
  * @author Jérémy Derussé <jeremy@derusse.com>
  *
  * @requires extension redis
+ * @group redis
  */
 class RedisStoreTest extends AbstractRedisStoreTest
 {
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/RedisCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/RedisCasterTest.php
@@ -17,6 +17,7 @@
 /**
  * @author Nicolas Grekas <p@tchwork.com>
  * @requires extension redis
+ * @group redis
  */
 class RedisCasterTest extends TestCase
 {
@@ -46,24 +47,25 @@ public function testNotConnected()
 
     public function testConnected()
     {
+        $redisHost = getenv('REDIS_HOST');
         $redis = new \Redis();
-        if (!@$redis->connect('127.0.0.1')) {
+        if (!@$redis->connect($redisHost)) {
             $e = error_get_last();
             self::markTestSkipped($e['message']);
         }
 
         if (\defined('HHVM_VERSION_ID')) {
-            $xCast = <<<'EODUMP'
+            $xCast = <<<EODUMP
 Redis {
-  #host: "127.0.0.1"
+  #host: "$redisHost"
 %A
 }
 EODUMP;
         } else {
-            $xCast = <<<'EODUMP'
+            $xCast = <<<EODUMP
 Redis {%A
   isConnected: true
-  host: "127.0.0.1"
+  host: "$redisHost"
   port: 6379
   auth: null
   dbNum: 0

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,7 @@ public function testCachePools()`
`24`	`24`
`25`	`25`	`/**`
`26`	`26`	`* @requires extension redis`
	`27`	`+ * @group redis`
`27`	`28`	`*/`
`28`	`29`	`public function testRedisCachePools()`
`29`	`30`	`{`
`@@ -49,6 +50,7 @@ public function testRedisCachePools()`
`49`	`50`
`50`	`51`	`/**`
`51`	`52`	`* @requires extension redis`
	`53`	`+ * @group redis`
`52`	`54`	`*/`
`53`	`55`	`public function testRedisCustomCachePools()`
`54`	`56`	`{`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,9 @@`
`14`	`14`	`use Predis\Connection\StreamConnection;`
`15`	`15`	`use Symfony\Component\Cache\Adapter\RedisAdapter;`
`16`	`16`
	`17`	`+/**`
	`18`	`+ * @group redis`
	`19`	`+ */`
`17`	`20`	`class PredisAdapterTest extends AbstractRedisAdapterTest`
`18`	`21`	`{`
`19`	`22`	`public static function setUpBeforeClass()`
Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,9 @@`
`11`	`11`
`12`	`12`	`namespace Symfony\Component\Cache\Tests\Adapter;`
`13`	`13`
	`14`	`+/**`
	`15`	`+ * @group redis`
	`16`	`+ */`
`14`	`17`	`class PredisClusterAdapterTest extends AbstractRedisAdapterTest`
`15`	`18`	`{`
`16`	`19`	`public static function setUpBeforeClass()`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,9 @@`
`15`	`15`	`use Symfony\Component\Cache\Adapter\RedisAdapter;`
`16`	`16`	`use Symfony\Component\Cache\Traits\RedisProxy;`
`17`	`17`
	`18`	`+/**`
	`19`	`+ * @group redis`
	`20`	`+ */`
`18`	`21`	`class RedisAdapterTest extends AbstractRedisAdapterTest`
`19`	`22`	`{`
`20`	`23`	`public static function setUpBeforeClass()`