bug #19126 [PhpUnitBridge] use call_user_func() for PHP 5.3 compatibility (xabbuh)

fabpot · fabpot · commit 26eca5d8c99a · 2016-06-21T09:23:35.000+02:00
This PR was merged into the 3.2-dev branch.

Discussion
----------

[PhpUnitBridge] use call_user_func() for PHP 5.3 compatibility

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Not all callables can be called directly on PHP 5.3 (for example, `array('className', 'methodName')` does not work).

Commits
-------

8549e05 use call_user_func() for PHP 5.3 compatibility
diff --git a/src/Symfony/Bridge/PhpUnit/ErrorAssert.php b/src/Symfony/Bridge/PhpUnit/ErrorAssert.php
@@ -53,7 +53,7 @@ public static function assertErrorsAreTriggered($expectedType, $expectedMessages
                 $triggeredMessages[] = $message;
             });
 
-            $testCode();
+            call_user_func($testCode);
         } catch (\Exception $e) {
         } catch (\Throwable $e) {
         }

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public static function assertErrorsAreTriggered($expectedType, $expectedMessages`
`53`	`53`	`$triggeredMessages[] = $message;`
`54`	`54`	`});`
`55`	`55`
`56`		`- $testCode();`
	`56`	`+ call_user_func($testCode);`
`57`	`57`	`} catch (\Exception $e) {`
`58`	`58`	`} catch (\Throwable $e) {`
`59`	`59`	`}`