Deprecated precision option in favor of scale

wouterj · wouterj · commit 2a2f7e2c8250 · 2015-04-03T16:31:32.000+02:00
diff --git a/UPGRADE-3.0.md b/UPGRADE-3.0.md
@@ -106,6 +106,24 @@ UPGRADE FROM 2.x to 3.0
 
 ### Form
 
+ * The option "precision" was renamed to "scale".
+
+   Before:
+
+   ```php
+   $builder->add('length', 'number', array(
+      'precision' => 3,
+   ));
+   ```
+
+   After:
+
+   ```php
+   $builder->add('length', 'number', array(
+      'scale' => 3,
+   ));
+   ```
+
  * The method `AbstractType::setDefaultOptions(OptionsResolverInterface $resolver)` and
    `AbstractTypeExtension::setDefaultOptions(OptionsResolverInterface $resolver)` have been
    renamed. You should use `AbstractType::configureOptions(OptionsResolver $resolver)` and
diff --git a/src/Symfony/Component/Form/CHANGELOG.md b/src/Symfony/Component/Form/CHANGELOG.md
@@ -4,6 +4,7 @@ CHANGELOG
 2.7.0
 -----
 
+ * deprecated option "precision" in favor of "scale"
  * deprecated the overwriting of AbstractType::setDefaultOptions() in favor of overwriting AbstractType::configureOptions().
  * deprecated the overwriting of AbstractTypeExtension::setDefaultOptions() in favor of overwriting AbstractTypeExtension::configureOptions().
 
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/IntegerToLocalizedStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/IntegerToLocalizedStringTransformer.php
@@ -22,11 +22,11 @@ class IntegerToLocalizedStringTransformer extends NumberToLocalizedStringTransfo
     /**
      * Constructs a transformer.
      *
-     * @param int  $precision    Unused.
+     * @param int  $scale        Unused.
      * @param bool $grouping     Whether thousands should be grouped.
      * @param int  $roundingMode One of the ROUND_ constants in this class.
      */
-    public function __construct($precision = 0, $grouping = false, $roundingMode = self::ROUND_DOWN)
+    public function __construct($scale = 0, $grouping = false, $roundingMode = self::ROUND_DOWN)
     {
         if (null === $roundingMode) {
             $roundingMode = self::ROUND_DOWN;
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/MoneyToLocalizedStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/MoneyToLocalizedStringTransformer.php
@@ -23,17 +23,17 @@ class MoneyToLocalizedStringTransformer extends NumberToLocalizedStringTransform
 {
     private $divisor;
 
-    public function __construct($precision = 2, $grouping = true, $roundingMode = self::ROUND_HALF_UP, $divisor = 1)
+    public function __construct($scale = 2, $grouping = true, $roundingMode = self::ROUND_HALF_UP, $divisor = 1)
     {
         if (null === $grouping) {
             $grouping = true;
         }
 
-        if (null === $precision) {
-            $precision = 2;
+        if (null === $scale) {
+            $scale = 2;
         }
 
-        parent::__construct($precision, $grouping, $roundingMode);
+        parent::__construct($scale, $grouping, $roundingMode);
 
         if (null === $divisor) {
             $divisor = 1;
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/NumberToLocalizedStringTransformer.php
@@ -93,13 +93,16 @@ class NumberToLocalizedStringTransformer implements DataTransformerInterface
      */
     const ROUND_HALFDOWN = \NumberFormatter::ROUND_HALFDOWN;
 
+    /**
+     * @deprecated since version 2.7, will be replaced by a $scale private property in 3.0.
+     */
     protected $precision;
 
     protected $grouping;
 
     protected $roundingMode;
 
-    public function __construct($precision = null, $grouping = false, $roundingMode = self::ROUND_HALF_UP)
+    public function __construct($scale = null, $grouping = false, $roundingMode = self::ROUND_HALF_UP)
     {
         if (null === $grouping) {
             $grouping = false;
@@ -109,7 +112,7 @@ public function __construct($precision = null, $grouping = false, $roundingMode
             $roundingMode = self::ROUND_HALF_UP;
         }
 
-        $this->precision = $precision;
+        $this->precision = $scale;
         $this->grouping = $grouping;
         $this->roundingMode = $roundingMode;
     }
@@ -240,7 +243,7 @@ protected function getNumberFormatter()
     }
 
     /**
-     * Rounds a number according to the configured precision and rounding mode.
+     * Rounds a number according to the configured scale and rounding mode.
      *
      * @param int|float $number A number.
      *
@@ -249,7 +252,7 @@ protected function getNumberFormatter()
     private function round($number)
     {
         if (null !== $this->precision && null !== $this->roundingMode) {
-            // shift number to maintain the correct precision during rounding
+            // shift number to maintain the correct scale during rounding
             $roundingCoef = pow(10, $this->precision);
             $number *= $roundingCoef;
 
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/PercentToLocalizedStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/PercentToLocalizedStringTransformer.php
@@ -33,22 +33,22 @@ class PercentToLocalizedStringTransformer implements DataTransformerInterface
 
     private $type;
 
-    private $precision;
+    private $scale;
 
     /**
      * Constructor.
      *
      * @see self::$types for a list of supported types
      *
-     * @param int    $precision The precision
-     * @param string $type      One of the supported types
+     * @param int    $scale The scale
+     * @param string $type  One of the supported types
      *
      * @throws UnexpectedTypeException if the given value of type is unknown
      */
-    public function __construct($precision = null, $type = null)
+    public function __construct($scale = null, $type = null)
     {
-        if (null === $precision) {
-            $precision = 0;
+        if (null === $scale) {
+            $scale = 0;
         }
 
         if (null === $type) {
@@ -60,7 +60,7 @@ public function __construct($precision = null, $type = null)
         }
 
         $this->type = $type;
-        $this->precision = $precision;
+        $this->scale = $scale;
     }
 
     /**
@@ -142,7 +142,7 @@ protected function getNumberFormatter()
     {
         $formatter = new \NumberFormatter(\Locale::getDefault(), \NumberFormatter::DECIMAL);
 
-        $formatter->setAttribute(\NumberFormatter::FRACTION_DIGITS, $this->precision);
+        $formatter->setAttribute(\NumberFormatter::FRACTION_DIGITS, $this->scale);
 
         return $formatter;
     }
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/IntegerType.php b/src/Symfony/Component/Form/Extension/Core/Type/IntegerType.php
@@ -14,6 +14,7 @@
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\Form\Extension\Core\DataTransformer\IntegerToLocalizedStringTransformer;
+use Symfony\Component\OptionsResolver\Options;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 class IntegerType extends AbstractType
@@ -25,7 +26,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
     {
         $builder->addViewTransformer(
             new IntegerToLocalizedStringTransformer(
-                $options['precision'],
+                $options['scale'],
                 $options['grouping'],
                 $options['rounding_mode']
         ));
@@ -36,9 +37,19 @@ public function buildForm(FormBuilderInterface $builder, array $options)
      */
     public function configureOptions(OptionsResolver $resolver)
     {
+        $scale = function (Options $options) {
+            if (null !== $options['precision']) {
+                trigger_error('The form option "precision" is deprecated since version 2.7 and will be removed in 3.0. Use "scale" instead.', E_USER_DEPRECATED);
+            }
+
+            return $options['precision'];
+        };
+
         $resolver->setDefaults(array(
-            // default precision is locale specific (usually around 3)
+            // deprecated as of Symfony 2.7, to be removed in Symfony 3.0.
             'precision' => null,
+            // default scale is locale specific (usually around 3)
+            'scale' => $scale,
             'grouping' => false,
             // Integer cast rounds towards 0, so do the same when displaying fractions
             'rounding_mode' => IntegerToLocalizedStringTransformer::ROUND_DOWN,
@@ -56,6 +67,8 @@ public function configureOptions(OptionsResolver $resolver)
                 IntegerToLocalizedStringTransformer::ROUND_CEILING,
             ),
         ));
+
+        $resolver->setAllowedTypes('scale', array('null', 'int'));
     }
 
     /**
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/MoneyType.php b/src/Symfony/Component/Form/Extension/Core/Type/MoneyType.php
@@ -16,6 +16,7 @@
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\Form\Extension\Core\DataTransformer\MoneyToLocalizedStringTransformer;
 use Symfony\Component\Form\FormView;
+use Symfony\Component\OptionsResolver\Options;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 class MoneyType extends AbstractType
@@ -29,7 +30,7 @@ public function buildForm(FormBuilderInterface $builder, array $options)
     {
         $builder
             ->addViewTransformer(new MoneyToLocalizedStringTransformer(
-                $options['precision'],
+                $options['scale'],
                 $options['grouping'],
                 null,
                 $options['divisor']
@@ -50,13 +51,27 @@ public function buildView(FormView $view, FormInterface $form, array $options)
      */
     public function configureOptions(OptionsResolver $resolver)
     {
+        $scale = function (Options $options) {
+            if (null !== $options['precision']) {
+                trigger_error('The form option "precision" is deprecated since version 2.7 and will be removed in 3.0. Use "scale" instead.', E_USER_DEPRECATED);
+
+                return $options['precision'];
+            }
+
+            return 2;
+        };
+
         $resolver->setDefaults(array(
-            'precision' => 2,
+            // deprecated as of Symfony 2.7, to be removed in Symfony 3.0
+            'precision' => null,
+            'scale' => $scale,
             'grouping' => false,
             'divisor' => 1,
             'currency' => 'EUR',
             'compound' => false,
         ));
+
+        $resolver->setAllowedTypes('scale', 'int');
     }
 
     /**
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/NumberType.php b/src/Symfony/Component/Form/Extension/Core/Type/NumberType.php
@@ -14,6 +14,7 @@
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\Form\Extension\Core\DataTransformer\NumberToLocalizedStringTransformer;
+use Symfony\Component\OptionsResolver\Options;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 class NumberType extends AbstractType
@@ -24,7 +25,7 @@ class NumberType extends AbstractType
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
         $builder->addViewTransformer(new NumberToLocalizedStringTransformer(
-            $options['precision'],
+            $options['scale'],
             $options['grouping'],
             $options['rounding_mode']
         ));
@@ -35,9 +36,19 @@ public function buildForm(FormBuilderInterface $builder, array $options)
      */
     public function configureOptions(OptionsResolver $resolver)
     {
+        $scale = function (Options $options) {
+            if (null !== $options['precision']) {
+                trigger_error('The form option "precision" is deprecated since version 2.7 and will be removed in 3.0. Use "scale" instead.', E_USER_DEPRECATED);
+            }
+
+            return $options['precision'];
+        };
+
         $resolver->setDefaults(array(
-            // default precision is locale specific (usually around 3)
+            // deprecated as of Symfony 2.7, to be removed in Symfony 3.0
             'precision' => null,
+            // default scale is locale specific (usually around 3)
+            'scale' => $scale,
             'grouping' => false,
             'rounding_mode' => NumberToLocalizedStringTransformer::ROUND_HALF_UP,
             'compound' => false,
@@ -54,6 +65,8 @@ public function configureOptions(OptionsResolver $resolver)
                 NumberToLocalizedStringTransformer::ROUND_CEILING,
             ),
         ));
+
+        $resolver->setAllowedTypes('scale', array('null', 'int'));
     }
 
     /**
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/PercentType.php b/src/Symfony/Component/Form/Extension/Core/Type/PercentType.php
@@ -14,6 +14,7 @@
 use Symfony\Component\Form\AbstractType;
 use Symfony\Component\Form\FormBuilderInterface;
 use Symfony\Component\Form\Extension\Core\DataTransformer\PercentToLocalizedStringTransformer;
+use Symfony\Component\OptionsResolver\Options;
 use Symfony\Component\OptionsResolver\OptionsResolver;
 
 class PercentType extends AbstractType
@@ -23,16 +24,28 @@ class PercentType extends AbstractType
      */
     public function buildForm(FormBuilderInterface $builder, array $options)
     {
-        $builder->addViewTransformer(new PercentToLocalizedStringTransformer($options['precision'], $options['type']));
+        $builder->addViewTransformer(new PercentToLocalizedStringTransformer($options['scale'], $options['type']));
     }
 
     /**
      * {@inheritdoc}
      */
     public function configureOptions(OptionsResolver $resolver)
     {
+        $scale = function (Options $options) {
+            if (null !== $options['precision']) {
+                trigger_error('The form option "precision" is deprecated since version 2.7 and will be removed in 3.0. Use "scale" instead.', E_USER_DEPRECATED);
+
+                return $options['precision'];
+            }
+
+            return 0;
+        };
+
         $resolver->setDefaults(array(
-            'precision' => 0,
+            // deprecated as of Symfony 2.7, to be removed in Symfony 3.0.
+            'precision' => null,
+            'scale' => $scale,
             'type' => 'fractional',
             'compound' => false,
         ));
@@ -43,6 +56,8 @@ public function configureOptions(OptionsResolver $resolver)
                 'integer',
             ),
         ));
+
+        $resolver->setAllowedTypes('scale', 'int');
     }
 
     /**
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/NumberToLocalizedStringTransformerTest.php
@@ -74,7 +74,7 @@ public function testTransformWithGrouping($from, $to, $locale)
         $this->assertSame($to, $transformer->transform($from));
     }
 
-    public function testTransformWithPrecision()
+    public function testTransformWithScale()
     {
         $transformer = new NumberToLocalizedStringTransformer(2);
 
@@ -174,14 +174,14 @@ public function transformWithRoundingProvider()
     /**
      * @dataProvider transformWithRoundingProvider
      */
-    public function testTransformWithRounding($precision, $input, $output, $roundingMode)
+    public function testTransformWithRounding($scale, $input, $output, $roundingMode)
     {
-        $transformer = new NumberToLocalizedStringTransformer($precision, null, $roundingMode);
+        $transformer = new NumberToLocalizedStringTransformer($scale, null, $roundingMode);
 
         $this->assertEquals($output, $transformer->transform($input));
     }
 
-    public function testTransformDoesNotRoundIfNoPrecision()
+    public function testTransformDoesNotRoundIfNoScale()
     {
         $transformer = new NumberToLocalizedStringTransformer(null, null, NumberToLocalizedStringTransformer::ROUND_DOWN);
 
@@ -327,14 +327,14 @@ public function reverseTransformWithRoundingProvider()
     /**
      * @dataProvider reverseTransformWithRoundingProvider
      */
-    public function testReverseTransformWithRounding($precision, $input, $output, $roundingMode)
+    public function testReverseTransformWithRounding($scale, $input, $output, $roundingMode)
     {
-        $transformer = new NumberToLocalizedStringTransformer($precision, null, $roundingMode);
+        $transformer = new NumberToLocalizedStringTransformer($scale, null, $roundingMode);
 
         $this->assertEquals($output, $transformer->reverseTransform($input));
     }
 
-    public function testReverseTransformDoesNotRoundIfNoPrecision()
+    public function testReverseTransformDoesNotRoundIfNoScale()
     {
         $transformer = new NumberToLocalizedStringTransformer(null, null, NumberToLocalizedStringTransformer::ROUND_DOWN);
 
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/PercentToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/PercentToLocalizedStringTransformerTest.php
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/NumberTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/NumberTypeTest.php

Original file line number	Diff line number	Diff line change
`@@ -22,11 +22,11 @@ class IntegerToLocalizedStringTransformer extends NumberToLocalizedStringTransfo`
`22`	`22`	`/**`
`23`	`23`	`* Constructs a transformer.`
`24`	`24`	`*`
`25`		`- * @param int $precision Unused.`
	`25`	`+ * @param int $scale Unused.`
`26`	`26`	`* @param bool $grouping Whether thousands should be grouped.`
`27`	`27`	`* @param int $roundingMode One of the ROUND_ constants in this class.`
`28`	`28`	`*/`
`29`		`- public function __construct($precision = 0, $grouping = false, $roundingMode = self::ROUND_DOWN)`
	`29`	`+ public function __construct($scale = 0, $grouping = false, $roundingMode = self::ROUND_DOWN)`
`30`	`30`	`{`
`31`	`31`	`if (null === $roundingMode) {`
`32`	`32`	`$roundingMode = self::ROUND_DOWN;`
Original file line number	Diff line number	Diff line change
`@@ -23,17 +23,17 @@ class MoneyToLocalizedStringTransformer extends NumberToLocalizedStringTransform`
`23`	`23`	`{`
`24`	`24`	`private $divisor;`
`25`	`25`
`26`		`- public function __construct($precision = 2, $grouping = true, $roundingMode = self::ROUND_HALF_UP, $divisor = 1)`
	`26`	`+ public function __construct($scale = 2, $grouping = true, $roundingMode = self::ROUND_HALF_UP, $divisor = 1)`
`27`	`27`	`{`
`28`	`28`	`if (null === $grouping) {`
`29`	`29`	`$grouping = true;`
`30`	`30`	`}`
`31`	`31`
`32`		`- if (null === $precision) {`
`33`		`- $precision = 2;`
	`32`	`+ if (null === $scale) {`
	`33`	`+ $scale = 2;`
`34`	`34`	`}`
`35`	`35`
`36`		`- parent::__construct($precision, $grouping, $roundingMode);`
	`36`	`+ parent::__construct($scale, $grouping, $roundingMode);`
`37`	`37`
`38`	`38`	`if (null === $divisor) {`
`39`	`39`	`$divisor = 1;`
Original file line number	Diff line number	Diff line change
`@@ -93,13 +93,16 @@ class NumberToLocalizedStringTransformer implements DataTransformerInterface`
`93`	`93`	`*/`
`94`	`94`	`const ROUND_HALFDOWN = \NumberFormatter::ROUND_HALFDOWN;`
`95`	`95`
	`96`	`+ /**`
	`97`	`+ * @deprecated since version 2.7, will be replaced by a $scale private property in 3.0.`
	`98`	`+ */`
`96`	`99`	`protected $precision;`
`97`	`100`
`98`	`101`	`protected $grouping;`
`99`	`102`
`100`	`103`	`protected $roundingMode;`
`101`	`104`
`102`		`- public function __construct($precision = null, $grouping = false, $roundingMode = self::ROUND_HALF_UP)`
	`105`	`+ public function __construct($scale = null, $grouping = false, $roundingMode = self::ROUND_HALF_UP)`
`103`	`106`	`{`
`104`	`107`	`if (null === $grouping) {`
`105`	`108`	`$grouping = false;`
`@@ -109,7 +112,7 @@ public function __construct($precision = null, $grouping = false, $roundingMode`
`109`	`112`	`$roundingMode = self::ROUND_HALF_UP;`
`110`	`113`	`}`
`111`	`114`
`112`		`- $this->precision = $precision;`
	`115`	`+ $this->precision = $scale;`
`113`	`116`	`$this->grouping = $grouping;`
`114`	`117`	`$this->roundingMode = $roundingMode;`
`115`	`118`	`}`
`@@ -240,7 +243,7 @@ protected function getNumberFormatter()`
`240`	`243`	`}`
`241`	`244`
`242`	`245`	`/**`
`243`		`- * Rounds a number according to the configured precision and rounding mode.`
	`246`	`+ * Rounds a number according to the configured scale and rounding mode.`
`244`	`247`	`*`
`245`	`248`	`* @param int\|float $number A number.`
`246`	`249`	`*`
`@@ -249,7 +252,7 @@ protected function getNumberFormatter()`
`249`	`252`	`private function round($number)`
`250`	`253`	`{`
`251`	`254`	`if (null !== $this->precision && null !== $this->roundingMode) {`
`252`		`- // shift number to maintain the correct precision during rounding`
	`255`	`+ // shift number to maintain the correct scale during rounding`
`253`	`256`	`$roundingCoef = pow(10, $this->precision);`
`254`	`257`	`$number *= $roundingCoef;`
`255`	`258`
Original file line number	Diff line number	Diff line change
`@@ -33,22 +33,22 @@ class PercentToLocalizedStringTransformer implements DataTransformerInterface`
`33`	`33`
`34`	`34`	`private $type;`
`35`	`35`
`36`		`- private $precision;`
	`36`	`+ private $scale;`
`37`	`37`
`38`	`38`	`/**`
`39`	`39`	`* Constructor.`
`40`	`40`	`*`
`41`	`41`	`* @see self::$types for a list of supported types`
`42`	`42`	`*`
`43`		`- * @param int $precision The precision`
`44`		`- * @param string $type One of the supported types`
	`43`	`+ * @param int $scale The scale`
	`44`	`+ * @param string $type One of the supported types`
`45`	`45`	`*`
`46`	`46`	`* @throws UnexpectedTypeException if the given value of type is unknown`
`47`	`47`	`*/`
`48`		`- public function __construct($precision = null, $type = null)`
	`48`	`+ public function __construct($scale = null, $type = null)`
`49`	`49`	`{`
`50`		`- if (null === $precision) {`
`51`		`- $precision = 0;`
	`50`	`+ if (null === $scale) {`
	`51`	`+ $scale = 0;`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`if (null === $type) {`
`@@ -60,7 +60,7 @@ public function __construct($precision = null, $type = null)`
`60`	`60`	`}`
`61`	`61`
`62`	`62`	`$this->type = $type;`
`63`		`- $this->precision = $precision;`
	`63`	`+ $this->scale = $scale;`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`/**`
`@@ -142,7 +142,7 @@ protected function getNumberFormatter()`
`142`	`142`	`{`
`143`	`143`	`$formatter = new \NumberFormatter(\Locale::getDefault(), \NumberFormatter::DECIMAL);`
`144`	`144`
`145`		`- $formatter->setAttribute(\NumberFormatter::FRACTION_DIGITS, $this->precision);`
	`145`	`+ $formatter->setAttribute(\NumberFormatter::FRACTION_DIGITS, $this->scale);`
`146`	`146`
`147`	`147`	`return $formatter;`
`148`	`148`	`}`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ public function testTransformWithGrouping($from, $to, $locale)`
`74`	`74`	`$this->assertSame($to, $transformer->transform($from));`
`75`	`75`	`}`
`76`	`76`
`77`		`- public function testTransformWithPrecision()`
	`77`	`+ public function testTransformWithScale()`
`78`	`78`	`{`
`79`	`79`	`$transformer = new NumberToLocalizedStringTransformer(2);`
`80`	`80`
`@@ -174,14 +174,14 @@ public function transformWithRoundingProvider()`
`174`	`174`	`/**`
`175`	`175`	`* @dataProvider transformWithRoundingProvider`
`176`	`176`	`*/`
`177`		`- public function testTransformWithRounding($precision, $input, $output, $roundingMode)`
	`177`	`+ public function testTransformWithRounding($scale, $input, $output, $roundingMode)`
`178`	`178`	`{`
`179`		`- $transformer = new NumberToLocalizedStringTransformer($precision, null, $roundingMode);`
	`179`	`+ $transformer = new NumberToLocalizedStringTransformer($scale, null, $roundingMode);`
`180`	`180`
`181`	`181`	`$this->assertEquals($output, $transformer->transform($input));`
`182`	`182`	`}`
`183`	`183`
`184`		`- public function testTransformDoesNotRoundIfNoPrecision()`
	`184`	`+ public function testTransformDoesNotRoundIfNoScale()`
`185`	`185`	`{`
`186`	`186`	`$transformer = new NumberToLocalizedStringTransformer(null, null, NumberToLocalizedStringTransformer::ROUND_DOWN);`
`187`	`187`
`@@ -327,14 +327,14 @@ public function reverseTransformWithRoundingProvider()`
`327`	`327`	`/**`
`328`	`328`	`* @dataProvider reverseTransformWithRoundingProvider`
`329`	`329`	`*/`
`330`		`- public function testReverseTransformWithRounding($precision, $input, $output, $roundingMode)`
	`330`	`+ public function testReverseTransformWithRounding($scale, $input, $output, $roundingMode)`
`331`	`331`	`{`
`332`		`- $transformer = new NumberToLocalizedStringTransformer($precision, null, $roundingMode);`
	`332`	`+ $transformer = new NumberToLocalizedStringTransformer($scale, null, $roundingMode);`
`333`	`333`
`334`	`334`	`$this->assertEquals($output, $transformer->reverseTransform($input));`
`335`	`335`	`}`
`336`	`336`
`337`		`- public function testReverseTransformDoesNotRoundIfNoPrecision()`
	`337`	`+ public function testReverseTransformDoesNotRoundIfNoScale()`
`338`	`338`	`{`
`339`	`339`	`$transformer = new NumberToLocalizedStringTransformer(null, null, NumberToLocalizedStringTransformer::ROUND_DOWN);`
`340`	`340`