Remove BC layer

MatTheCat · MatTheCat · commit 2ac4d710b2ae · 2023-07-11T22:12:30.000+02:00
diff --git a/src/Symfony/Bundle/SecurityBundle/Security.php b/src/Symfony/Bundle/SecurityBundle/Security.php
@@ -109,7 +109,7 @@ public function getFirewallConfig(Request $request): ?FirewallConfig
      *
      * @return Response|null The authenticator success response if any
      */
-    public function login(UserInterface $user, string $authenticatorName = null, string $firewallName = null /* array $badges = [] */): ?Response
+    public function login(UserInterface $user, string $authenticatorName = null, string $firewallName = null, array $badges = []): ?Response
     {
         $request = $this->container->get('request_stack')->getCurrentRequest();
         $firewallName ??= $this->getFirewallConfig($request)?->getName();
@@ -122,7 +122,7 @@ public function login(UserInterface $user, string $authenticatorName = null, str
 
         $this->container->get('security.user_checker')->checkPreAuth($user);
 
-        return $this->container->get('security.authenticator.managers_locator')->get($firewallName)->authenticateUser($user, $authenticator, $request, 4 <= \func_num_args() ? func_get_arg(3) : []);
+        return $this->container->get('security.authenticator.managers_locator')->get($firewallName)->authenticateUser($user, $authenticator, $request, $badges);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ public function getFirewallConfig(Request $request): ?FirewallConfig`
`109`	`109`	`*`
`110`	`110`	`* @return Response\|null The authenticator success response if any`
`111`	`111`	`*/`
`112`		`- public function login(UserInterface $user, string $authenticatorName = null, string $firewallName = null /* array $badges = [] */): ?Response`
	`112`	`+ public function login(UserInterface $user, string $authenticatorName = null, string $firewallName = null, array $badges = []): ?Response`
`113`	`113`	`{`
`114`	`114`	`$request = $this->container->get('request_stack')->getCurrentRequest();`
`115`	`115`	`$firewallName ??= $this->getFirewallConfig($request)?->getName();`
`@@ -122,7 +122,7 @@ public function login(UserInterface $user, string $authenticatorName = null, str`
`122`	`122`
`123`	`123`	`$this->container->get('security.user_checker')->checkPreAuth($user);`
`124`	`124`
`125`		`- return $this->container->get('security.authenticator.managers_locator')->get($firewallName)->authenticateUser($user, $authenticator, $request, 4 <= \func_num_args() ? func_get_arg(3) : []);`
	`125`	`+ return $this->container->get('security.authenticator.managers_locator')->get($firewallName)->authenticateUser($user, $authenticator, $request, $badges);`
`126`	`126`	`}`
`127`	`127`
`128`	`128`	`/**`