fix IPv6 address handling in server commands

xabbuh · xabbuh · commit 2bb47136df50 · 2016-12-30T11:19:53.000+01:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/ServerCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/ServerCommand.php
@@ -54,7 +54,9 @@ protected function isOtherServerProcessRunning($address)
             return true;
         }
 
-        list($hostname, $port) = explode(':', $address);
+        $pos = strrpos($address, ':');
+        $hostname = substr($address, 0, $pos);
+        $port = substr($address, $pos + 1);
 
         $fp = @fsockopen($hostname, $port, $errno, $errstr, 5);
 

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,9 @@ protected function isOtherServerProcessRunning($address)`
`54`	`54`	`return true;`
`55`	`55`	`}`
`56`	`56`
`57`		`- list($hostname, $port) = explode(':', $address);`
	`57`	`+ $pos = strrpos($address, ':');`
	`58`	`+ $hostname = substr($address, 0, $pos);`
	`59`	`+ $port = substr($address, $pos + 1);`
`58`	`60`
`59`	`61`	`$fp = @fsockopen($hostname, $port, $errno, $errstr, 5);`
`60`	`62`