feature #15905 [3.0][Config] Removed isFresh() related functionality (WouterJ)

fabpot · fabpot · commit 30fc4eea13eb · 2015-09-27T11:06:17.000+02:00
This PR was merged into the 3.0-dev branch.

Discussion
----------

[3.0][Config] Removed isFresh() related functionality

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

4cdae98 Removed Resource#isFresh() related functionality
diff --git a/src/Symfony/Bundle/FrameworkBundle/Resources/config/services.xml b/src/Symfony/Bundle/FrameworkBundle/Resources/config/services.xml
@@ -49,12 +49,5 @@
             <tag name="config_cache.resource_checker" priority="-990" />
         </service>
 
-        <!--
-            This service is deprecated and will be removed in 3.0.
-        -->
-        <service class="Symfony\Component\Config\Resource\BCResourceInterfaceChecker" public="false">
-            <tag name="config_cache.resource_checker" priority="-1000" />
-        </service>
-
     </services>
 </container>
diff --git a/src/Symfony/Component/Config/CHANGELOG.md b/src/Symfony/Component/Config/CHANGELOG.md
@@ -5,6 +5,8 @@ CHANGELOG
 -----
 
  * removed `ReferenceDumper` class
+ * removed the `ResourceInterface::isFresh()` method
+ * removed `BCResourceInterfaceChecker` class
 
 2.8.0
 -----
diff --git a/src/Symfony/Component/Config/ConfigCache.php b/src/Symfony/Component/Config/ConfigCache.php
@@ -11,7 +11,6 @@
 
 namespace Symfony\Component\Config;
 
-use Symfony\Component\Config\Resource\BCResourceInterfaceChecker;
 use Symfony\Component\Config\Resource\SelfCheckingResourceChecker;
 
 /**
@@ -21,11 +20,6 @@
  * \Symfony\Component\Config\Resource\SelfCheckingResourceInterface will
  * be used to check cache freshness.
  *
- * During a transition period, also instances of
- * \Symfony\Component\Config\Resource\ResourceInterface will be checked
- * by means of the isFresh() method. This behaviour is deprecated since 2.8
- * and will be removed in 3.0.
- *
  * @author Fabien Potencier <fabien@symfony.com>
  * @author Matthias Pigulla <mp@webfactory.de>
  */
@@ -41,7 +35,6 @@ public function __construct($file, $debug)
     {
         parent::__construct($file, array(
             new SelfCheckingResourceChecker(),
-            new BCResourceInterfaceChecker(),
         ));
         $this->debug = (bool) $debug;
     }
diff --git a/src/Symfony/Component/Config/Resource/BCResourceInterfaceChecker.php b/src/Symfony/Component/Config/Resource/BCResourceInterfaceChecker.php
diff --git a/src/Symfony/Component/Config/Resource/ResourceInterface.php b/src/Symfony/Component/Config/Resource/ResourceInterface.php
@@ -31,18 +31,6 @@ interface ResourceInterface
      */
     public function __toString();
 
-    /**
-     * Returns true if the resource has not been updated since the given timestamp.
-     *
-     * @param int $timestamp The last time the resource was loaded
-     *
-     * @return bool True if the resource has not been updated, false otherwise
-     *
-     * @deprecated since 2.8, to be removed in 3.0. If your resource can check itself for
-     *             freshness implement the SelfCheckingResourceInterface instead.
-     */
-    public function isFresh($timestamp);
-
     /**
      * Returns the tied resource.
      *
