bug #13987 [WebProfilerBundle] fixed undefined buttons variable. (aitboudad)

fabpot · fabpot · commit 32da9634729f · 2015-03-21T18:44:13.000+01:00
This PR was merged into the 2.6 branch. Discussion ---------- [WebProfilerBundle] fixed undefined buttons variable. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | #13974, #13636 | Tests pass? | yes | License | MIT Commits ------- a8c4da1 [WebProfilerBundle] fixed undefined buttons.
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/form.html.twig b/src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/form.html.twig
@@ -373,7 +373,7 @@
                         throw "Tab target " + targetId + " does not exist";
                     }
 
-                    clickHandler(buttons[i], select);
+                    clickHandler(tabs[i], select);
 
                     Sfjs.addClass(target, 'hidden');
                 }
@@ -398,7 +398,7 @@
                     e = window.event;
                 }
 
-                callback(e.target || e.srcElement);
+                callback(this);
 
                 if (e.preventDefault) {
                     e.preventDefault();

Original file line number	Diff line number	Diff line change
`@@ -373,7 +373,7 @@`
`373`	`373`	`throw "Tab target " + targetId + " does not exist";`
`374`	`374`	`}`
`375`	`375`
`376`		`- clickHandler(buttons[i], select);`
	`376`	`+ clickHandler(tabs[i], select);`
`377`	`377`
`378`	`378`	`Sfjs.addClass(target, 'hidden');`
`379`	`379`	`}`
`@@ -398,7 +398,7 @@`
`398`	`398`	`e = window.event;`
`399`	`399`	`}`
`400`	`400`
`401`		`- callback(e.target \|\| e.srcElement);`
	`401`	`+ callback(this);`
`402`	`402`
`403`	`403`	`if (e.preventDefault) {`
`404`	`404`	`e.preventDefault();`