Add validation of the returned locks

alexander-schranz · alexander-schranz · commit 392cf850693e · 2024-12-12T19:42:36.000+01:00
diff --git a/src/Symfony/Component/Semaphore/Store/LockStore.php b/src/Symfony/Component/Semaphore/Store/LockStore.php
@@ -81,9 +81,9 @@ public function putOffExpiration(Key $key, float $ttlInSecond): void
     }
 
     /**
-     * @return iterable<LockInterface>
+     * @return array<LockInterface>
      */
-    private function getLocks(Key $key, float $ttlInSecond, bool $create): iterable
+    private function getLocks(Key $key, float $ttlInSecond, bool $create): array
     {
         $lockName = base64_encode($key->__toString());
 
@@ -118,6 +118,15 @@ private function getLocks(Key $key, float $ttlInSecond, bool $create): iterable
             $key->setState(__CLASS__, $locks);
         } elseif ($key->hasState(__CLASS__)) {
             $locks = $key->getState(__CLASS__);
+            \assert((function () use ($locks) {
+                foreach ($locks as $lock) {
+                    if (!$lock instanceof LockInterface) {
+                        return false;
+                    }
+                }
+
+                return true;
+            })() === true, 'Locks must be an array of LockInterface');
         }
 
         return $locks;
