Fix issue which prevent the profiler to explain a query

Baachi · Baachi · commit 3b7bb6be49b4 · 2015-10-21T19:03:56.000+02:00
diff --git a/src/Symfony/Bridge/Doctrine/DataCollector/DoctrineDataCollector.php b/src/Symfony/Bridge/Doctrine/DataCollector/DoctrineDataCollector.php
@@ -117,6 +117,9 @@ private function sanitizeQueries($connectionName, $queries)
     private function sanitizeQuery($connectionName, $query)
     {
         $query['explainable'] = true;
+        if (null === $query['params']) {
+            $query['params'] = array();
+        }
         if (!is_array($query['params'])) {
             $query['params'] = array($query['params']);
         }
diff --git a/src/Symfony/Bridge/Doctrine/Tests/DataCollector/DoctrineDataCollectorTest.php b/src/Symfony/Bridge/Doctrine/Tests/DataCollector/DoctrineDataCollectorTest.php
@@ -84,6 +84,22 @@ public function testCollectQueries($param, $types, $expected, $explainable)
         $this->assertEquals($explainable, $collected_queries['default'][0]['explainable']);
     }
 
+    public function testCollectQueryWithNoParams()
+    {
+        $queries = array(
+            array('sql' => 'SELECT * FROM table1', 'params' => array(), 'types' => array(), 'executionMS' => 1),
+            array('sql' => 'SELECT * FROM table1', 'params' => null, 'types' => null, 'executionMS' => 1),
+        );
+        $c = $this->createCollector($queries);
+        $c->collect(new Request(), new Response());
+
+        $collected_queries = $c->getQueries();
+        $this->assertEquals(array(), $collected_queries['default'][0]['params']);
+        $this->assertTrue($collected_queries['default'][0]['explainable']);
+        $this->assertEquals(array(), $collected_queries['default'][1]['params']);
+        $this->assertTrue($collected_queries['default'][1]['explainable']);
+    }
+
     /**
      * @dataProvider paramProvider
      */

Original file line number	Diff line number	Diff line change
`@@ -117,6 +117,9 @@ private function sanitizeQueries($connectionName, $queries)`
`117`	`117`	`private function sanitizeQuery($connectionName, $query)`
`118`	`118`	`{`
`119`	`119`	`$query['explainable'] = true;`
	`120`	`+ if (null === $query['params']) {`
	`121`	`+ $query['params'] = array();`
	`122`	`+ }`
`120`	`123`	`if (!is_array($query['params'])) {`
`121`	`124`	`$query['params'] = array($query['params']);`
`122`	`125`	`}`