bug #49025 [Notifier] [OvhCloud] handle invalid receiver (seferov)

fabpot · fabpot · commit 3bd051fd64f6 · 2023-01-19T20:18:56.000+01:00
This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Notifier] [OvhCloud] handle invalid receiver | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Fix `Undefined offset: 0` error when invalid receiver is provided Commits ------- d41f0bf [Notifier] [OvhCloud] handle invalid receiver
diff --git a/src/Symfony/Component/Notifier/Bridge/OvhCloud/OvhCloudTransport.php b/src/Symfony/Component/Notifier/Bridge/OvhCloud/OvhCloudTransport.php
@@ -121,6 +121,10 @@ protected function doSend(MessageInterface $message): SentMessage
 
         $success = $response->toArray(false);
 
+        if (!isset($success['ids'][0])) {
+            throw new TransportException(sprintf('Attempt to send the SMS to invalid receivers: "%s".', implode(',', $success['invalidReceivers'])), $response);
+        }
+
         $sentMessage = new SentMessage($message, (string) $this);
         $sentMessage->setMessageId($success['ids'][0]);
 
diff --git a/src/Symfony/Component/Notifier/Bridge/OvhCloud/Tests/OvhCloudTransportTest.php b/src/Symfony/Component/Notifier/Bridge/OvhCloud/Tests/OvhCloudTransportTest.php
@@ -14,6 +14,7 @@
 use Symfony\Component\HttpClient\MockHttpClient;
 use Symfony\Component\HttpClient\Response\MockResponse;
 use Symfony\Component\Notifier\Bridge\OvhCloud\OvhCloudTransport;
+use Symfony\Component\Notifier\Exception\TransportException;
 use Symfony\Component\Notifier\Message\ChatMessage;
 use Symfony\Component\Notifier\Message\MessageInterface;
 use Symfony\Component\Notifier\Message\SmsMessage;
@@ -92,4 +93,26 @@ public function testValidSignature(string $message)
         $toSign = 'applicationSecret+consumerKey+POST+'.$endpoint.'+'.$body.'+'.$time;
         $this->assertSame('$1$'.sha1($toSign), $signature);
     }
+
+    public function testInvalidReceiver()
+    {
+        $smsMessage = new SmsMessage('invalid_receiver', 'lorem ipsum');
+
+        $data = json_encode([
+            'totalCreditsRemoved' => '1',
+            'invalidReceivers' => ['invalid_receiver'],
+            'ids' => [],
+            'validReceivers' => [],
+        ]);
+        $responses = [
+            new MockResponse((string) time()),
+            new MockResponse($data),
+        ];
+
+        $transport = $this->createTransport(new MockHttpClient($responses));
+
+        $this->expectException(TransportException::class);
+        $this->expectExceptionMessage('Attempt to send the SMS to invalid receivers: "invalid_receiver"');
+        $transport->send($smsMessage);
+    }
 }
