minor #52190 [FrameworkBundle] Fix requiring moved translation compiler passes (fancyweb)

nicolas-grekas · nicolas-grekas · commit 4292cc0a0292 · 2023-10-20T08:43:25.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle] Fix requiring moved translation compiler passes | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #52032 (comment) | License | MIT Those 2 also need to be required conditionally since symfony/translation is not a hard dependency of FWB. Commits ------- 2b95681 [FrameworkBundle] Fix requiring moved translation compiler passes
diff --git a/src/Symfony/Bundle/FrameworkBundle/FrameworkBundle.php b/src/Symfony/Bundle/FrameworkBundle/FrameworkBundle.php
@@ -144,7 +144,7 @@ public function build(ContainerBuilder $container)
         $container->addCompilerPass(new RegisterControllerArgumentLocatorsPass());
         $container->addCompilerPass(new RemoveEmptyControllerArgumentLocatorsPass(), PassConfig::TYPE_BEFORE_REMOVING);
         $container->addCompilerPass(new RoutingResolverPass());
-        $container->addCompilerPass(new DataCollectorTranslatorPass());
+        $this->addCompilerPassIfExists($container, DataCollectorTranslatorPass::class);
         $container->addCompilerPass(new ProfilerPass());
         // must be registered before removing private services as some might be listeners/subscribers
         // but as late as possible to get resolved parameters
@@ -157,7 +157,7 @@ public function build(ContainerBuilder $container)
         // twig.template_iterator definition
         $this->addCompilerPassIfExists($container, TranslatorPass::class, PassConfig::TYPE_BEFORE_OPTIMIZATION, -32);
         $this->addCompilerPassIfExists($container, TranslatorPathsPass::class, PassConfig::TYPE_AFTER_REMOVING);
-        $container->addCompilerPass(new LoggingTranslatorPass());
+        $this->addCompilerPassIfExists($container, LoggingTranslatorPass::class);
         $container->addCompilerPass(new AddExpressionLanguageProvidersPass());
         $this->addCompilerPassIfExists($container, TranslationExtractorPass::class);
         $this->addCompilerPassIfExists($container, TranslationDumperPass::class);
