bug #52298 [HttpKernel] Update AbstractBundle.php, use !isset($this->path) (tacman)

nicolas-grekas · nicolas-grekas · commit 4406087cb75e · 2023-10-25T22:48:43.000+02:00
This PR was merged into the 7.0 branch. Discussion ---------- [HttpKernel] Update AbstractBundle.php, use !isset($this->path) Fixes issue #52292 | Q | A | ------------- | --- | Branch? | 7.0 | Bug fix? | yes | New feature? no | Deprecations?no | Issues | Fix #52292 | License | MIT Check for isset rather than accessing the property before initialization. ``` !! Error {#111 !! #message: "Typed property Symfony\Component\HttpKernel\Bundle\Bundle::$path must not be accessed before initialization" !! #code: 0 !! #file: "./vendor/symfony/http-kernel/Bundle/AbstractBundle.php" !! #line: 53 !! trace: { ``` Commits ------- c59f4c5 Update AbstractBundle.php, use !isset($this->path)
diff --git a/src/Symfony/Component/HttpKernel/Bundle/AbstractBundle.php b/src/Symfony/Component/HttpKernel/Bundle/AbstractBundle.php
@@ -50,7 +50,7 @@ public function getContainerExtension(): ?ExtensionInterface
 
     public function getPath(): string
     {
-        if (null === $this->path) {
+        if (!isset($this->path)) {
             $reflected = new \ReflectionObject($this);
             // assume the modern directory structure by default
             $this->path = \dirname($reflected->getFileName(), 2);

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ public function getContainerExtension(): ?ExtensionInterface`
`50`	`50`
`51`	`51`	`public function getPath(): string`
`52`	`52`	`{`
`53`		`- if (null === $this->path) {`
	`53`	`+ if (!isset($this->path)) {`
`54`	`54`	`$reflected = new \ReflectionObject($this);`
`55`	`55`	`// assume the modern directory structure by default`
`56`	`56`	`$this->path = \dirname($reflected->getFileName(), 2);`