bug #12180 Prevent an empty choice list being passed in debug:container (weaverryan)

fabpot · fabpot · commit 4430f75e898b · 2014-10-09T01:30:22.000+02:00
This PR was squashed before being merged into the 2.6-dev branch (closes #12180). Discussion ---------- Prevent an empty choice list being passed in debug:container Hi guys! | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | -- | License | MIT | Doc PR | n/a Currently, there is a "bug" where if you pass an empty array to ChoiceList, then you get this following warning from `QuestionHelper::doAsk()`: > Warning: max(): Array must contain at least one element That should probably be fixed too, but it would go on an earlier version, so I didn't want to mix fixes for different branches. Thanks! Commits ------- ef23b63 Prevent an empty choice list being passed in debug:container
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
@@ -184,7 +184,12 @@ private function findProperServiceName(InputInterface $input, OutputInterface $o
             return $name;
         }
 
-        $question = new ChoiceQuestion('Choose a number for more information on the service', $this->findServiceIdsContaining($builder, $name));
+        $matchingServices = $this->findServiceIdsContaining($builder, $name);
+        if (empty($matchingServices)) {
+            throw new \InvalidArgumentException(sprintf('No services found that match "%s".', $name));
+        }
+
+        $question = new ChoiceQuestion('Choose a number for more information on the service', $matchingServices);
         $question->setErrorMessage('Service %s is invalid.');
 
         return $this->getHelper('question')->ask($input, $output, $question);
