bug #38291 [OptionsResolver] Fix deprecation message access (fancyweb)

fabpot · fabpot · commit 44bd82cb2d70 · 2020-09-25T07:58:26.000+02:00
This PR was merged into the 5.1 branch. Discussion ---------- [OptionsResolver] Fix deprecation message access | Q | A | ------------- | --- | Branch? | 5.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - `$this->deprecated[$option]` cannot be a string, it's always an array. Commits ------- 232af42 [OptionsResolver] Fix deprecation message access
diff --git a/src/Symfony/Component/OptionsResolver/OptionsResolver.php b/src/Symfony/Component/OptionsResolver/OptionsResolver.php
@@ -1067,7 +1067,7 @@ public function offsetGet($option, bool $triggerDeprecation = true)
 
         // Check whether the option is deprecated
         // and it is provided by the user or is being called from a lazy evaluation
-        if ($triggerDeprecation && isset($this->deprecated[$option]) && (isset($this->given[$option]) || ($this->calling && \is_string($this->deprecated[$option])))) {
+        if ($triggerDeprecation && isset($this->deprecated[$option]) && (isset($this->given[$option]) || ($this->calling && \is_string($this->deprecated[$option]['message'])))) {
             $deprecation = $this->deprecated[$option];
             $message = $this->deprecated[$option]['message'];
 
