minor #23987 [Intl] Change number PHPDoc type to int|float (PurpleBooth)

fabpot · fabpot · commit 459e6cbc908e · 2017-08-26T06:09:48.000-07:00
This PR was merged into the 2.7 branch. Discussion ---------- [Intl] Change number PHPDoc type to int|float While number is a valid type inside PHP internally, it's not a part of the PHPDoc standard. This causes IDEs and static analysers to raise errors on this function. The internal PHP type `number` is the same as `int|float`, this changes the type to that. https://php.net/manual/en/language.pseudo-types.php#language.types.number https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc.md#keyword | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- c7601cb Change number PHPDoc type to int|float
diff --git a/src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php b/src/Symfony/Component/Intl/NumberFormatter/NumberFormatter.php
@@ -355,9 +355,9 @@ public function formatCurrency($value, $currency)
     /**
      * Format a number.
      *
-     * @param number $value The value to format
-     * @param int    $type  Type of the formatting, one of the format type constants
-     *                      Only type NumberFormatter::TYPE_DEFAULT is currently supported.
+     * @param int|float $value The value to format
+     * @param int       $type  Type of the formatting, one of the format type constants
+     *                         Only type NumberFormatter::TYPE_DEFAULT is currently supported.
      *
      * @return bool|string The formatted value or false on error
      *

Original file line number	Diff line number	Diff line change
`@@ -355,9 +355,9 @@ public function formatCurrency($value, $currency)`
`355`	`355`	`/**`
`356`	`356`	`* Format a number.`
`357`	`357`	`*`
`358`		`- * @param number $value The value to format`
`359`		`- * @param int $type Type of the formatting, one of the format type constants`
`360`		`- * Only type NumberFormatter::TYPE_DEFAULT is currently supported.`
	`358`	`+ * @param int\|float $value The value to format`
	`359`	`+ * @param int $type Type of the formatting, one of the format type constants`
	`360`	`+ * Only type NumberFormatter::TYPE_DEFAULT is currently supported.`
`361`	`361`	`*`
`362`	`362`	`* @return bool\|string The formatted value or false on error`
`363`	`363`	`*`