Skip to content

Commit 4652a60

Browse files
committed
Merge branch '2.8'
* 2.8: Use PHPUnit 5.0 for PHP 7 [DomCrawler] always pass base href to subcrawlers
2 parents 4913362 + b938a7f commit 4652a60

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

phpunit

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,14 @@
33

44
error_reporting(-1);
55

6-
$PHPUNIT_VERSION = 4.8;
6+
$PHPUNIT_VERSION = '4.8';
77
$PHPUNIT_DIR = __DIR__.'/.phpunit';
88

9+
// PHPUnit 4.8 does not support PHP 7, while 5.0 requires PHP 5.6+
10+
if (PHP_VERSION_ID >= 70000) {
11+
$PHPUNIT_DIR = '5.0';
12+
}
13+
914
if (!file_exists("$PHPUNIT_DIR/phpunit-$PHPUNIT_VERSION/phpunit")) {
1015
// Build a standalone phpunit without symfony/yaml
1116

0 commit comments

Comments
 (0)