bug #29057 [HttpFoundation] replace any preexisting Content-Type headers (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 46e3745a03e1 · 2018-11-08T22:38:31.000+01:00
This PR was merged into the 2.8 branch. Discussion ---------- [HttpFoundation] replace any preexisting Content-Type headers | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21204 | License | MIT | Doc PR | - Commits ------- de2ce58 [HttpFoundation] replace any preexisting Content-Type headers
diff --git a/src/Symfony/Component/HttpFoundation/Response.php b/src/Symfony/Component/HttpFoundation/Response.php
@@ -344,8 +344,9 @@ public function sendHeaders()
 
         // headers
         foreach ($this->headers->allPreserveCase() as $name => $values) {
+            $replace = 0 === strcasecmp($name, 'Content-Type');
             foreach ($values as $value) {
-                header($name.': '.$value, false, $this->statusCode);
+                header($name.': '.$value, $replace, $this->statusCode);
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -344,8 +344,9 @@ public function sendHeaders()`
`344`	`344`
`345`	`345`	`// headers`
`346`	`346`	`foreach ($this->headers->allPreserveCase() as $name => $values) {`
	`347`	`+ $replace = 0 === strcasecmp($name, 'Content-Type');`
`347`	`348`	`foreach ($values as $value) {`
`348`		`- header($name.': '.$value, false, $this->statusCode);`
	`349`	`+ header($name.': '.$value, $replace, $this->statusCode);`
`349`	`350`	`}`
`350`	`351`	`}`
`351`	`352`