[Yaml] fail when parsing mappings without keys

xabbuh · xabbuh · commit 47e720a2b24c · 2017-02-17T08:52:39.000+01:00
diff --git a/src/Symfony/Component/Yaml/Inline.php b/src/Symfony/Component/Yaml/Inline.php
@@ -384,6 +384,10 @@ private static function parseMapping($mapping, &$i = 0, $references = array())
             // key
             $key = self::parseScalar($mapping, array(':', ' '), array('"', "'"), $i, false);
 
+            if (':' === $key) {
+                throw new ParseException('A mapping without a key is invalid.');
+            }
+
             // value
             $done = false;
 
diff --git a/src/Symfony/Component/Yaml/Tests/InlineTest.php b/src/Symfony/Component/Yaml/Tests/InlineTest.php
@@ -420,4 +420,22 @@ public function testVeryLongQuotedStrings()
 
         $this->assertEquals($longStringWithQuotes, $arrayFromYaml['longStringWithQuotes']);
     }
+
+    public function testBooleanMappingKeysAreConvertedToStrings()
+    {
+        $this->assertSame(array('false' => 'foo'), Inline::parse('{false: foo}'));
+    }
+
+    public function testTheEmptyStringIsAValidMappingKey()
+    {
+        $this->assertSame(array('' => 'foo'), Inline::parse('{ "": foo }'));
+    }
+
+    /**
+     * @expectedException \Symfony\Component\Yaml\Exception\ParseException
+     */
+    public function testMappingKeysCannotBeOmitted()
+    {
+        Inline::parse('{: foo}');
+    }
 }
