[Messenger] Fix Oracle errors 'ORA-00955: Name is already used by an existing object' with Doctrine transport

atgitwk · atgitwk · commit 49b57f021e41 · 2025-04-13T21:24:45.000+02:00
diff --git a/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Doctrine/Transport/Connection.php
@@ -302,7 +302,9 @@ public function setup(): void
                 throw new \TypeError(\sprintf('The table name must be an instance of "%s" or a string ("%s" given).', AbstractAsset::class, get_debug_type($tableName)));
             }
 
-            return $tableName === $this->configuration['table_name'];
+            // SchemaAssetsFilter needs to match the messenger table name and also the messenger sequence name to make $schemaDiff work correctly in updateSchema()
+            // This may also work for other databases if their sequence name is suffixed with '_seq', '_id_seq' or similar.
+            return str_starts_with($tableName, $this->configuration['table_name']); // MESSENGER_MESSAGES*
         });
         $this->updateSchema();
         $configuration->setSchemaAssetsFilter($assetFilter);
@@ -533,9 +535,14 @@ private function addTableToSchema(Schema $schema): void
 
         // We need to create a sequence for Oracle and set the id column to get the correct nextval
         if ($this->driverConnection->getDatabasePlatform() instanceof OraclePlatform) {
-            $idColumn->setDefault($this->configuration['table_name'].self::ORACLE_SEQUENCES_SUFFIX.'.nextval');
+            $serverVersion = $this->driverConnection->getWrappedConnection()->getServerVersion();
+            if (version_compare($serverVersion, '12.1.0', '>=')) {
+                $idColumn->setAutoincrement(false); // disable the creation of SEQUENCE and TRIGGER
+                // The line below is taken into account only if Oracle version is >= 12.1.0
+                $idColumn->setDefault($this->configuration['table_name'].self::ORACLE_SEQUENCES_SUFFIX.'.nextval');
 
-            $schema->createSequence($this->configuration['table_name'].self::ORACLE_SEQUENCES_SUFFIX);
+                $schema->createSequence($this->configuration['table_name'].self::ORACLE_SEQUENCES_SUFFIX);
+            }
         }
     }
 
