minor #40484 [DependencyInjection] accept null index in #[TaggedItem] (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 49d23d481362 · 2021-03-16T20:14:20.000+01:00
This PR was merged into the 5.3-dev branch. Discussion ---------- [DependencyInjection] accept null index in #[TaggedItem] | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As hinted by @stof in #40248 (comment) Commits ------- 6d16fac [DI] accept null index in #[TaggedItem]
diff --git a/src/Symfony/Component/DependencyInjection/Attribute/TaggedItem.php b/src/Symfony/Component/DependencyInjection/Attribute/TaggedItem.php
@@ -20,7 +20,7 @@
 class TaggedItem
 {
     public function __construct(
-        public string $index,
+        public ?string $index = null,
         public ?int $priority = null,
     ) {
     }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/PriorityTaggedServiceTraitTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/PriorityTaggedServiceTraitTest.php
@@ -205,13 +205,17 @@ public function testTaggedItemAttributes()
                 HelloNamedService::class => (new ChildDefinition(''))->addTag('my_custom_tag'),
                 \stdClass::class => (new ChildDefinition(''))->addTag('my_custom_tag2'),
             ]);
+        $container->register('service3', HelloNamedService2::class)
+            ->setAutoconfigured(true)
+            ->addTag('my_custom_tag');
 
         (new ResolveInstanceofConditionalsPass())->process($container);
 
         $priorityTaggedServiceTraitImplementation = new PriorityTaggedServiceTraitImplementation();
 
         $tag = new TaggedIteratorArgument('my_custom_tag', 'foo', 'getFooBar');
         $expected = [
+            'service3' => new TypedReference('service3', HelloNamedService2::class),
             'hello' => new TypedReference('service2', HelloNamedService::class),
             'service1' => new TypedReference('service1', FooTagClass::class),
         ];
@@ -235,3 +239,8 @@ public function test($tagName, ContainerBuilder $container)
 class HelloNamedService extends \stdClass
 {
 }
+
+#[TaggedItem(priority: 2)]
+class HelloNamedService2
+{
+}

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@`
`20`	`20`	`class TaggedItem`
`21`	`21`	`{`
`22`	`22`	`public function __construct(`
`23`		`- public string $index,`
	`23`	`+ public ?string $index = null,`
`24`	`24`	`public ?int $priority = null,`
`25`	`25`	`) {`
`26`	`26`	`}`