bug #42307 [Mailer] Fixed decode exception when sendgrid response is 202 (rubanooo)

fabpot · fabpot · commit 4a285973891a · 2021-07-29T08:26:45.000+02:00
This PR was submitted for the 5.3 branch but it was squashed and merged into the 4.4 branch instead. Discussion ---------- [Mailer] Fixed decode exception when sendgrid response is 202 | Q | A | ------------- | --- | Branch? | 5.4 for features / 4.4, 5.2 or 5.3 for bug fixes  | Bug fix? | yes | New feature? | no  | Deprecations? | no  | Tickets | Fix #42306  | License | MIT | Doc PR | symfony/symfony-docs#...   Commits ------- 9c6d31a [Mailer] Fixed decode exception when sendgrid response is 202
diff --git a/src/Symfony/Component/Mailer/Bridge/Sendgrid/Transport/SendgridApiTransport.php b/src/Symfony/Component/Mailer/Bridge/Sendgrid/Transport/SendgridApiTransport.php
@@ -54,15 +54,18 @@ protected function doSendApi(SentMessage $sentMessage, Email $email, Envelope $e
 
         try {
             $statusCode = $response->getStatusCode();
-            $result = $response->toArray(false);
-        } catch (DecodingExceptionInterface $e) {
-            throw new HttpTransportException('Unable to send an email: '.$response->getContent(false).sprintf(' (code %d).', $statusCode), $response);
         } catch (TransportExceptionInterface $e) {
             throw new HttpTransportException('Could not reach the remote Sendgrid server.', $response, 0, $e);
         }
 
         if (202 !== $statusCode) {
-            throw new HttpTransportException('Unable to send an email: '.implode('; ', array_column($result['errors'], 'message')).sprintf(' (code %d).', $statusCode), $response);
+            try {
+                $result = $response->toArray(false);
+
+                throw new HttpTransportException('Unable to send an email: '.implode('; ', array_column($result['errors'], 'message')).sprintf(' (code %d).', $statusCode), $response);
+            } catch (DecodingExceptionInterface $e) {
+                throw new HttpTransportException('Unable to send an email: '.$response->getContent(false).sprintf(' (code %d).', $statusCode), $response);
+            }
         }
 
         $sentMessage->setMessageId($response->getHeaders(false)['x-message-id'][0]);
